Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-3882] Replace ng-gettext with gettext from superdesk #125

Merged
merged 7 commits into from
May 12, 2020
Merged

[SDESK-3882] Replace ng-gettext with gettext from superdesk #125

merged 7 commits into from
May 12, 2020

Conversation

MarkLark86
Copy link
Contributor

No description provided.

@MarkLark86 MarkLark86 added this to the 2.0 milestone May 11, 2020
@MarkLark86 MarkLark86 requested a review from tomaskikutis May 11, 2020 05:00
@tomaskikutis
Copy link
Member

We should avoid importing things from client-core directly. Can you instead create a helpers file, and put gettext from extensions API there on application start?

It's similar how extensions API is accessed from planning https://github.com/superdesk/superdesk-planning/blob/develop/client/index.js#L131

@MarkLark86
Copy link
Contributor Author

We should avoid importing things from client-core directly. Can you instead create a helpers file, and put gettext from extensions API there on application start?

It's similar how extensions API is accessed from planning https://github.com/superdesk/superdesk-planning/blob/develop/client/index.js#L131

Unfortunately we can't use the extensions API everywhere for gettext, as translations are also needed during the config phase to register activities.

This ticket was purely about removing older implementations of gettext. When we migrate to React, we will be in a better standing to utilise the Superdesk API

@MarkLark86 MarkLark86 merged commit 6ae499a into superdesk:develop May 12, 2020
@MarkLark86 MarkLark86 modified the milestones: 2.0, 1.34.0 May 27, 2020
@MarkLark86 MarkLark86 modified the milestones: 1.34.0, 1.33.1 Jun 3, 2020
@MarkLark86 MarkLark86 added the merged Merged into release branch label Jun 3, 2020
MarkLark86 added a commit to MarkLark86/superdesk-analytics that referenced this pull request Jun 3, 2020
@MarkLark86
[SDESK-3882] Replace ng-gettext with gettext from superdesk (superdes…
5590d00 
…k#125)

* [SDESK-3882] Replace ng-gettext with gettext from superdesk

* Fix lint errors
Remove translation warning when running tests

* Remove TODO comments

* Move import of gettext to utils file

* Fix flake error

* Use develop branch of planning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
merged Merged into release branch
Projects
None yet
Milestone
1.33.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkLark86 @tomaskikutis