Changes after review

superdesk · Feb 20, 2023 · 5243709 · 5243709
1 parent 10ce705
commit 5243709
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/scripts/apps/authoring-react/data-layer.ts b/scripts/apps/authoring-react/data-layer.ts
@@ -247,6 +247,9 @@ export const authoringStorageIArticle: IAuthoringStorage<IArticle> = {
 
             let diff = generatePatch(original, _current);
 
+            // Object patching is overriding fields of object type with diff.
+            // If we make changes to such a field it is not saved correctly.
+            // So we need to add all fields which are of object type to the diff object.
             Object.keys(diff).forEach((key) => {
                 if (isObject(diff[key])) {
                     diff[key] = _current[key];

diff --git a/scripts/apps/authoring/metadata/PlacesService.ts b/scripts/apps/authoring/metadata/PlacesService.ts
@@ -71,7 +71,7 @@ export default function PlacesServiceFactory(api, features, metadata) {
     class PlacesService implements IPlacesService {
         searchDateline(query: string, lang: string) {
             return this._searchGeonames(query, lang, true)
-                .then((geonames) => geonames.map(geoNameToCity))
+                .then((geonames) => geonames.map((x) => geoNameToCity(x)))
                 .catch(() => this._searchCities(query));
         }
 

diff --git a/scripts/core/superdesk-api.d.ts b/scripts/core/superdesk-api.d.ts
@@ -248,7 +248,6 @@ declare module 'superdesk-api' {
     }
 
     export type IDatelineValueOperational = {
-        day?: string;
         date?: string;
         source?: string;
         located?: ILocated;