Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the name of of the routing rule available for editing in the second step of the form [SDESK-6774] #4165

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

devketanpro
Copy link
Member

No description provided.

@devketanpro devketanpro requested a review from fritzSF December 23, 2022 12:38
Copy link
Contributor

@fritzSF fritzSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devketanpro , please don't use new CSS for common elements that are alreadt defined.
The structure should be like this:

<div class="button-group button-group--end button-group--comfort" role="group">
   <button class="btn" tabindex="0">Cancel</button>
   <button class="btn btn--primary" tabindex="0">Save</button>
   <button class="btn btn--primary" tabindex="0">Done</button>
</div>

inside the 'modal__body-footer' in this case.

Additionaly this will be needed to make it work:

.modal.modal--tabs .modal__body-footer {
    display: flex;
}

you can add this in /superdesk-client-core/styles/sass/sf-additional.scss

@devketanpro devketanpro requested a review from fritzSF December 23, 2022 13:41
@devketanpro devketanpro added this to the 2.7 milestone Dec 26, 2022
styles/sass/sf-additional.scss Outdated Show resolved Hide resolved
@devketanpro devketanpro merged commit 93a5fd4 into superdesk:develop Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants