Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGA sign off event listener #4339

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
thecalcc authored Oct 10, 2023

Unverified

This user has not yet uploaded their public signing key.
commit ccfa34b0e303f6e595de6b8f5e825050ee9ec2a4
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ export function AuthoringContainerDirective(authoringWorkspace: AuthoringWorkspa
scope: {},
require: 'sdAuthoringContainer',
link: function(scope, elem, attrs, ctrl) {
// Needed for authoring Angular. In authoring react we have a generic
// Needed only for authoring Angular. In authoring react we have a generic
// event ('resource:updated') which listens to all item changes.
scope.$on('author_approval:updated', (event) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment for the record that it's handled through resource:updated event in authoring-react and this one is only needed for angular-based authoring? You should also test that it actually works on authoring react too even if it's not used yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Needed for authoring Angular.

"Only needed for authoring Angular." would be better phrasing.

if (event.item_id == scope.item._id) {
Loading