[TGA-88] fix: Add item back to IPreviewComponentProps interface #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`item` is passed into Editor component but not Preview component, keep similar interfaces between those two allows common functionality between preview and edit. `item` is also used by preview components in extensions from both Belga and 360info
|
@thecalcc The E2E is also failing in that base branch. So I don't believe I have introduced any test failures in this PR |
thecalcc
approved these changes
Mar 27, 2024
Comment on lines
+14
to
+15
| item1: any; | ||
| item2: any; |
There was a problem hiding this comment.
Please type these two objects
| @@ -6,6 +6,7 @@ import {Button} from 'superdesk-ui-framework/react'; | |||
| import {gettext} from 'core/utils'; | |||
|
|
|||
| export function previewAuthoringEntity( | |||
| item: any, | |||
| @@ -3374,6 +3374,7 @@ declare module 'superdesk-api' { | |||
| } | |||
|
|
|||
| export interface IPreviewComponentProps<IValue, IConfig> { | |||
| item: any; | |||
thecalcc
approved these changes
Mar 27, 2024
Yep, I broke them, we have a fix in progress on a different branch that's not merged yet. No worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itemis passed into Editor component but not Preview component, keep similar interfaces between those two allows common functionality between preview and edit.itemis also used by preview components in extensions from both Belga and 360info