Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI translations #4531

Merged
merged 18 commits into from
Jun 13, 2024
Merged

AI translations #4531

merged 18 commits into from
Jun 13, 2024

Conversation

thecalcc
Copy link
Contributor

SDBELGA-810

@thecalcc thecalcc requested a review from tomaskikutis May 29, 2024 09:35
@tomaskikutis tomaskikutis changed the title First draft implementation AI translations Jun 4, 2024
tomaskikutis
tomaskikutis reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see 00:24 of the video you sent me - unpinning the widget should not change widget state.

Also get a proper video recorder so you can upload the video to github. When I record, it outputs 3mb per minute.

scripts/core/superdesk-api.d.ts Outdated Show resolved Hide resolved
scripts/api/translations.ts Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/extension.ts Outdated Show resolved Hide resolved
scripts/api/translations.ts Outdated Show resolved Hide resolved
scripts/apps/authoring/widgets/widgets.ts Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/ai-assistant.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/ai-assistant.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/translations/translations-body.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/translations/translations-footer.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/translations/translations-body.tsx Show resolved Hide resolved
@petrjasek petrjasek added this to the 2.8 milestone Jun 5, 2024
@thecalcc
Copy link
Contributor Author

thecalcc commented Jun 5, 2024

see 00:24 of the video you sent me - unpinning the widget should not change widget state.

Also get a proper video recorder so you can upload the video to github. When I record, it outputs 3mb per minute.

I have my internal recorder from macos. That's how it works, I guess the video quality is a lot better.

@thecalcc thecalcc requested a review from tomaskikutis June 7, 2024 07:09
@thecalcc
Copy link
Contributor Author

thecalcc commented Jun 7, 2024

Demo:

Screen.Recording.2024-06-04.at.16.04.58.mp4

tomaskikutis
tomaskikutis reviewed Jun 7, 2024
View reviewed changes
scripts/apps/authoring-react/toolbar/translate-modal.tsx Outdated Show resolved Hide resolved
scripts/apps/dashboard/widget-react.tsx Show resolved Hide resolved
scripts/extensions/ai-widget/src/configuration.ts Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/extension.ts Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/extension.ts Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/ai-assistant.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/ai-assistant.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/ai-assistant.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/ai-assistant.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/ai-assistant.tsx Outdated Show resolved Hide resolved
@thecalcc
Copy link
Contributor Author

@tomaskikutis All changes were addressed, except for state persistence related ones. Currently the functionality to switch tabs is broken because of that.

@thecalcc thecalcc requested a review from tomaskikutis June 10, 2024 10:25
tomaskikutis
tomaskikutis reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed state persistence. Feel free to modify.

scripts/core/superdesk-api.d.ts Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/summary/summary.tsx Show resolved Hide resolved
scripts/extensions/ai-widget/src/summary/summary-widget.tsx Show resolved Hide resolved
scripts/extensions/ai-widget/src/translations/translations-body.tsx Outdated Show resolved Hide resolved
scripts/extensions/ai-widget/src/translations/translations-widget.tsx Show resolved Hide resolved
@thecalcc thecalcc requested a review from tomaskikutis June 12, 2024 12:56
@thecalcc
Copy link
Contributor Author

@tomaskikutis for some reason npm run isn't failing locally for me. Can you check as well? I'll restart it here

tomaskikutis
tomaskikutis approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁 🎉

@tomaskikutis
Copy link
Member

you can ignore this Unknown provider: spellcheckProvider in unit tests and still merge it. It happens randomly once in a while.

@thecalcc thecalcc merged commit 82fc57a into superdesk:develop Jun 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@thecalcc @tomaskikutis @petrjasek