Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for shortcut buttons #4606

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix logic for shortcut buttons #4606

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3184e4
Fix logic for shortcut buttons
thecalcc Aug 20, 2024
97b4b46
use sdApi.navigation.isPersonalSpace
thecalcc Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/api/article.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,9 @@ function canPublishOnDesk(deskType: string): boolean {

function showPublishAndContinue(item: IArticle, dirty: boolean): boolean {
return appConfig.features?.customAuthoringTopbar?.publishAndContinue
&& sdApi.navigation.isPersonalSpace()
&& !sdApi.navigation.isPersonalSpace()
&& canPublishOnDesk(sdApi.desks.getDeskById(sdApi.desks.getCurrentDeskId()).desk_type)
&& authoringApiCommon.checkShortcutButtonAvailability(item, dirty, sdApi.navigation.isPersonalSpace());
&& authoringApiCommon.checkShortcutButtonAvailability(item, dirty);
}

function showCloseAndContinue(item: IArticle, dirty: boolean): boolean {
Expand Down
2 changes: 1 addition & 1 deletion scripts/api/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function currentPathStartsWith(
}

function isPersonalSpace(): boolean {
return !(ng.get('$location').path() === '/workspace/personal');
return ng.get('$location').path() === '/workspace/personal';
}

export const navigation = {
Expand Down
Loading