Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Go 1.22 #3145

Closed
Tracked by #157782
stefanb opened this issue Dec 27, 2023 · 1 comment · Fixed by #3161
Closed
Tracked by #157782

Support Go 1.22 #3145

stefanb opened this issue Dec 27, 2023 · 1 comment · Fixed by #3161

Comments

@stefanb
Copy link
Contributor

stefanb commented Dec 27, 2023 •
edited
Loading

Trying to build with Go 1.22

fails with errors:

  # gvisor.dev/gvisor/pkg/sync
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/gate_unsafe.go:114:3: undefined: goready
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/gate_unsafe.go:144:2: undefined: gopark
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/rwmutex_unsafe.go:76:3: undefined: semacquire
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/rwmutex_unsafe.go:102:4: undefined: semrelease
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/rwmutex_unsafe.go:152:3: undefined: semacquire
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/rwmutex_unsafe.go:179:3: undefined: semrelease
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/rwmutex_unsafe.go:207:3: undefined: semrelease
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/seqcount.go:87:6: undefined: canSpin
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230504175454-7b0a1988a28f/pkg/sync/seqcount.go:89:4: undefined: doSpin

Currently it is using gvisor from May 2023:

flyctl/go.mod

Line 178 in 363a4dd

gvisor.dev/gvisor v0.0.0-20230504175454-7b0a1988a28f // indirect

Likely the solution is to bump to newer (or latest) version of gvisor.dev/gvisor to include also Go 1.22 support from July 2023:

Similar gvisor bump was needed for Go 1.21:
@stefanb stefanb mentioned this issue Dec 27, 2023
Merged
@stefanb stefanb mentioned this issue Jan 6, 2024
Merged
3 tasks
@stefanb
Copy link
Contributor Author

stefanb commented Jan 7, 2024

Proposed fix implemented in #3161

dangra pushed a commit that referenced this issue Jan 10, 2024
@stefanb
Bump gvisor & wireguard to support Go 1.22 (#3161)
95f615f 
Support Go 1.22

ran:
go get golang.zx2c4.com/wireguard@latest
to get also the updated gvisor.dev/gvisor with Go 1.22 support from google/gvisor#9197

Fixes #3145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump gvisor & wireguard to support Go 1.22
1 participant
@stefanb