-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From toml to toml #3202
Merged
Merged
From toml to toml #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangra
force-pushed
the
from-toml-to-toml
branch
from
January 23, 2024 18:54
02391e8
to
83f0398
Compare
dangra
force-pushed
the
from-toml-to-toml
branch
from
January 23, 2024 19:23
02bcd90
to
74042e7
Compare
dangra
force-pushed
the
from-toml-to-toml
branch
from
January 23, 2024 20:50
39c3544
to
45f10ec
Compare
dangra
force-pushed
the
from-toml-to-toml
branch
from
January 23, 2024 21:10
cc71470
to
1428d14
Compare
dangra
force-pushed
the
from-toml-to-toml
branch
from
January 23, 2024 21:36
0f85178
to
e487acd
Compare
billyb2
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
banger pr 👍🏾
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why: While adding
gpus
to[[vm]]
section, I found that BurntSushi/toml lib serializes zero values of integer fields even ifomitempty
tag is set for the struct field.Sounds like a minor thing, but it is very awkward for fly.toml files created by
fly launch
whose[[vm]]
section looks like:How: Unfortunately BurntSushi won't fix it and suggests using an integer pointer (
*int
instead ofint
), so the other alternative was to switch to https://github.com/pelletier/go-toml that works like we expect and claims to be moreencoding/json
alike.As a big plus, this PR adds a test case to ensure reading a toml file and writing it back generates an equal configuration without missing sections nor new ones.
Related to:
json.Number
type pelletier/go-toml#923Documentation