-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename --only-regions, remove primary regions flag #3514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rad! Thanks for taking care of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖
Hi @benbjohnson , might be worth updating your example usages so that people aren't confused when viewing example usages after running the old
|
Just FYI - this kind of change is breaking, and can bust CI/CD workflows, which I just experienced. Might be nice to alias the old behavior or something. (I'm personally using a fork of https://github.com/superfly/fly-pr-review-apps) |
This also broke our CI workflow - and this is the second time this has happened in the past couple of months - please can you consider some kind of formal deprecation process with release notes to users. It's really hard to rely on fly for our production environments at the moment. |
Our CI workflow broke as well - on top of that we had to fork this repo to support some other basic flags. We need to have a way more stable deprecation process on this tools, otherwise we're gonna have to handle more friction on our side (which is the whole reason why we're using fly as provider). |
Adding another comment about breakage to our CI deployment process as well. In fact, in this case On my side, I guess I'm just gonna have to pin the deployment version. |
Thanks for the feedback everyone and I apologize for the breakage. I'll do a better job handling this in the future.
@supriyo-biswas The |
I opened an issue to discuss this problem more in depth: #3551 This change is very dangerous, people may simply replace Imagine what someone that was previously using --region may do when the flag is no longer working:
This just happened to me 2 different times breaking prod, I didn't really understand why at first |
Change Summary
This pull request removes the previous
--region
flag onfly deploy
as it overrode theprimary-region
setting in the config, which was surprising to say the least. I was originally going to rename it to--primary-region
but I don't see a good use case for overriding the primary region for a single deploy. We can add it back in if it's useful.I also renamed the
--only-regions
to--regions
but retained the--only-regions
alias for backwards compatibility.Fixes: #3509
Documentation