launch: always high-availability
#3562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why: turning off high availability is a footgun - launch presents as slightly higher level than raw machines. At its level of abstraction, one wouldn't assume a single host outage should take down an app.
To fix this mismatch of expectations,
fly launchwill always launch a high availability version of an app.If you need to run single machines, you naturally still have the primitives to do this via machines, but Fly Launch apps should always be high availability.
How: removing the high availability option from
fly launch. (partially, for now, until the UI catches up)Documentation