-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flaps
: retry on certain failure modes, such as 504s
#3601
base: master
Are you sure you want to change the base?
Commits on Jun 5, 2024
-
machine
: stub outRetry
andRetryRet
These functions allow retrying machine operations like machine creation, though there's no logic yet for determining which errors are *actually* transient, so behavior is still the same
Configuration menu - View commit details
-
Copy full SHA for 63540ad - Browse repository at this point
Copy the full SHA 63540adView commit details -
machine
: local backoff state instead of globalbackoff modifies the Backoff state object while using it, so having one globally makes me uncomfortable
Configuration menu - View commit details
-
Copy full SHA for 2281f08 - Browse repository at this point
Copy the full SHA 2281f08View commit details -
Configuration menu - View commit details
-
Copy full SHA for a44ac51 - Browse repository at this point
Copy the full SHA a44ac51View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0714e5 - Browse repository at this point
Copy the full SHA e0714e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb76c76 - Browse repository at this point
Copy the full SHA fb76c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26189f7 - Browse repository at this point
Copy the full SHA 26189f7View commit details -
machine
: useRetry
in mostinternal/machine
functionsexcept for ephemeral machines - i'm cooking up a different strategy to do this so this is more of a check-in than anything
Configuration menu - View commit details
-
Copy full SHA for 49e38ba - Browse repository at this point
Copy the full SHA 49e38baView commit details -
Revert "
machine
: useRetry
in mostinternal/machine
functions"This reverts commit 49e38ba.
Configuration menu - View commit details
-
Copy full SHA for 6b9ce0f - Browse repository at this point
Copy the full SHA 6b9ce0fView commit details -
Revert "
machine
:Retry
now supports timeouts"This reverts commit fb76c76.
Configuration menu - View commit details
-
Copy full SHA for 8be65da - Browse repository at this point
Copy the full SHA 8be65daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 033a418 - Browse repository at this point
Copy the full SHA 033a418View commit details -
flaps
: wrap the Flaps client with a retryerSince Flaps has been abstracted to an Interface in flyctl, we can add a retry layer to it by just wrapping the existing client with *few* changes made elsewhere This is just a drop-in reliability improvement
Configuration menu - View commit details
-
Copy full SHA for 331f222 - Browse repository at this point
Copy the full SHA 331f222View commit details
Commits on Jun 6, 2024
-
retryClient
: restrict retry to GET and ops that should be idempotentGoing to have to follow up to see whether all of these are safe to retry, but I feel like they *should* be?
Configuration menu - View commit details
-
Copy full SHA for 16db045 - Browse repository at this point
Copy the full SHA 16db045View commit details