Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry scanner #3623

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Poetry scanner #3623

merged 3 commits into from
Jun 12, 2024

Conversation

fliepeltje
Copy link
Contributor

Change Summary

What and Why:
Building on the stuff used for scanning FastAPI, this now does a similar thing for more python projects using poetry:

  • flask
  • streamlit
  • FastAPI

In addition, tweaks the fastapi config to be more compatible with the framework docs of how to setup the app.

How:

Related to:


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

Copy link
Contributor

@rubys rubys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool.

You still have some cleanup to do to make the build pass.

  • Add a comment to your defer file.Close() call to get it not to be flagged. Example here:
    defer f.Close() // skipcq: GO-S2307
  • listSuffixedFiles is no longer used so it needs to be removed; you can run lint locally by running make lint. You may need to install golangci-lint first.

@fliepeltje
Copy link
Contributor Author

Great catch on the listSuffixedFiles - totally forgot about it!

I have golangci-lint installed, but make lint is not working well for me; running it directly without make is fine though 🙃

@rubys rubys self-requested a review June 12, 2024 13:09
@fliepeltje fliepeltje merged commit 4fefe6b into master Jun 12, 2024
34 checks passed
@fliepeltje fliepeltje deleted the poetry-scanner branch June 12, 2024 15:06
Copy link

sentry-io bot commented Jun 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ *runtime.TypeAssertionError: interface conversion: interface {} is nil, not map[string]interface {} github.com/superfly/flyctl/internal/sentry in R... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants