Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add machine status info about import/migration event #3632

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

aschiavo
Copy link
Contributor

Change Summary

What and Why:
This change notifies the user when a machine was created by flyd because of a migration action.
It's a first iteration while a better solution is implemented in nomad-firecracker.

This change notifies the user when a machine was created by flyd because
of a migration action.

It's a first iteration while a better solution is implemented in
nomad-firecracker.
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the example output? If possible, I'd like to use migration/migrated instead of import.

@aschiavo
Copy link
Contributor Author

@kzys This is the output for the command:

 go run . m status -a aschiavo-epic-stack-691c
? Select a machine: d8dd625fed5568 crimson-grass-559 (started, region qmx, process group 'app')
Machine ID: d8dd625fed5568
Instance ID: 01J08P60K8NK33K9P5MQ5M4QN8
State: started

VM
  ID            = d8dd625fed5568
  Instance ID   = 01J08P60K8NK33K9P5MQ5M4QN8
  State         = started
  Image         = aschiavo-epic-stack-691c:deployment-01HW81ZEKCE8GB6GV7506VCS7T
  Name          = crimson-grass-559
  Private IP    = fdaa:5:a89e:a7b:152:c79c:e922:2
  Region        = qmx
  Process Group = app
  CPU Kind      = shared
  vCPUs         = 1
  Memory        = 1024
  Created       = 2024-06-13T11:36:59Z
  Updated       = 2024-06-13T11:37:01Z
  Entrypoint    =
  Command       =
  Volume        = vol_r6gzo1p3yq83yxjv

Checks [0/3]
NAME                            STATUS          LAST UPDATED    OUTPUT
servicecheck-02-http-8080       critical        5h39m ago       connect: connection refused
servicecheck-01-http-8080       critical        5h39m ago       connect: connection refused
servicecheck-00-tcp-8080        critical        5h39m ago       connect: connection refused

Event Logs
STATE   EVENT   SOURCE  TIMESTAMP                       INFO
started start   flyd    2024-06-13T13:37:01.36+02:00
created launch  flyd    2024-06-13T13:36:59.864+02:00   import=true

Sounds good to me to change to migration/migrated , I went with import for consistency with flyd isImport but from user perspective is probably clearer if we go with something migration-related .
Do you have a preference for either migration or migrated? I'll make the change tomorrow morning

@kzys
Copy link
Member

kzys commented Jun 13, 2024

Yeah. import is our internal lingo. Personally I like migrated=true

@aschiavo
Copy link
Contributor Author

Done!

@aschiavo aschiavo merged commit d618f10 into master Jun 18, 2024
34 checks passed
@aschiavo aschiavo deleted the aschiavo/add-details-to-created-event-on-migrate branch June 18, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants