Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fly machines suspend #3633

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Add fly machines suspend #3633

merged 2 commits into from
Jun 14, 2024

Conversation

matttpt
Copy link
Contributor

@matttpt matttpt commented Jun 13, 2024

Change Summary

What and Why:

As part of the new suspend/resume feature, add a new fly machines command to suspend a Machine.

How:

Use the new Suspend flaps client method from fly-go, which in turn uses the new suspend endpoint in flaps, and support for the suspended state added to the wait endpoint.

This PR upgrades fly-go to v0.1.17.

Related to:


Documentation

I will be in touch with the docs team, and there will be a Fresh Produce when we're ready.

@matttpt matttpt changed the title [DO NOT MERGE] Add fly machines suspend Add fly machines suspend Jun 14, 2024
@matttpt matttpt marked this pull request as ready for review June 14, 2024 16:38
Copy link
Member

@dangra dangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small fix required. pre-approving.

internal/command/machine/suspend.go Outdated Show resolved Hide resolved
@matttpt matttpt merged commit ba27404 into master Jun 14, 2024
34 of 35 checks passed
@matttpt matttpt deleted the machines-suspend-command branch June 14, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants