Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display proxy ephemeral port when the user specifies 0 #3639

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jonatanklosko
Copy link
Contributor

The current behaviour is to print 0, which is not meaningful:

$ fly proxy 0:5558 ...
Proxying local port 0 to remote [...]:5558

With this change we special case port 0 and print the actual ephemeral port assigned to the listener.

@dangra dangra merged commit 7d04cd5 into superfly:master Jun 20, 2024
7 checks passed
@dangra
Copy link
Member

dangra commented Jun 20, 2024

thanks @jonatanklosko

@jonatanklosko jonatanklosko deleted the jk-proxy-port-zero branch June 20, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants