Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling of "fulfill" in error message #3656

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix spelling of "fulfill" in error message #3656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/command/deploy/machines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ func (md *machineDeployment) validateVolumeConfig() error {
if len(missing) > 0 {
// TODO: May change this by a prompt to create new volumes right away (?)
return fmt.Errorf(
"Process group '%s' needs volumes with name '%s' to fullfill mounts defined in fly.toml; "+
"Process group '%s' needs volumes with name '%s' to fulfill mounts defined in fly.toml; "+
"Run `fly volume create %s -r REGION -n COUNT` for the following regions and counts: %s",
groupName, volSrc, volSrc, strings.Join(missing, " "),
)
Expand Down
2 changes: 1 addition & 1 deletion test/preflight/fly_deploy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func TestFlyDeployHA(t *testing.T) {
`, f.ReadFile("fly.toml"))

x := f.FlyAllowExitFailure("deploy")
require.Contains(f, x.StdErrString(), `needs volumes with name 'data' to fullfill mounts defined in fly.toml`)
require.Contains(f, x.StdErrString(), `needs volumes with name 'data' to fulfill mounts defined in fly.toml`)

// Create two volumes because fly launch will start 2 machines because of HA setup
f.Fly("volume create -a %s -r %s -s 1 data -y", appName, f.PrimaryRegion())
Expand Down
Loading