launch: better incomplete manifest visibility

internal/command/launch/cmd.go

@@ -191,6 +191,9 @@ func run(ctx context.Context) (err error) {
 		if err != nil {
 			tracing.RecordError(span, err, "launch failed")
 			status.Error = err.Error()
+			if info := flyerr.GetErrorDebugInfo(err); info != "" {
+				status.Error += "\n" + info
+			}
 
 			if state != nil && state.sourceInfo != nil && state.sourceInfo.FailureCallback != nil {
 				err = state.sourceInfo.FailureCallback(err)
@@ -288,7 +291,7 @@ func run(ctx context.Context) (err error) {
 		summary,
 	)
 
-	if errors := recoverableErrors.build(); errors != "" {
+	if errors := recoverableErrors.buildDisplayableErrorList(); errors != "" {
 
 		fmt.Fprintf(io.ErrOut, "\n%s\n%s\n", aurora.Reverse(aurora.Red("The following problems must be fixed in the Launch UI:")), errors)
 		incompleteLaunchManifest = true
@@ -314,7 +317,7 @@ func run(ctx context.Context) (err error) {
 		}
 	} else if incompleteLaunchManifest {
 		// UI was required to reconcile launch issues, but user denied. Abort.
-		return errors.New("launch can not continue with errors present")
+		return recoverableErrors.toError()
 	}
 
 	err = state.Launch(ctx)

internal/command/launch/plan_builder.go

@@ -88,7 +88,7 @@ func (r *recoverableErrorBuilder) tryRecover(e error) error {
 	return e
 }
 
-func (r *recoverableErrorBuilder) build() string {
+func (r *recoverableErrorBuilder) buildDisplayableErrorList() string {
 	if len(r.errors) == 0 {
 		return ""
 	}
@@ -100,6 +100,27 @@ func (r *recoverableErrorBuilder) build() string {
 	return allErrors
 }
 
+func (r *recoverableErrorBuilder) toError() error {
+	if len(r.errors) == 0 {
+		return nil
+	}
+	return IncompleteManifestError{
+		debug: r.buildDisplayableErrorList(),
+	}
+}
+
+type IncompleteManifestError struct {
+	debug string
+}
+
+func (e IncompleteManifestError) Error() string {
+	return "launch can not continue with errors present"
+}
+
+func (e IncompleteManifestError) DebugInfo() string {
+	return e.debug
+}
+
 func buildManifest(ctx context.Context, recoverableErrors *recoverableErrorBuilder) (*LaunchManifest, *planBuildCache, error) {
 	io := iostreams.FromContext(ctx)
 

internal/flyerr/flyerr.go

@@ -127,3 +127,17 @@ func IsCancelledError(err error) bool {
 
 	return false
 }
+
+// ErrorDebugInfo is an error with debug information that should be attached to metrics, logs, or sent to Sentry
+type ErrorDebugInfo interface {
+	error
+	DebugInfo() string
+}
+
+func GetErrorDebugInfo(err error) string {
+	var ferr ErrorDebugInfo
+	if errors.As(err, &ferr) {
+		return ferr.DebugInfo()
+	}
+	return ""
+}