-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fly pg connect
to work with custom images
#3680
Conversation
You can currently specify |
Oh, didn't notice that. This PR makes it unnecessary. Any thoughts about getting rid of FLY_DEV? I don't see any risk here. |
The The main problem is that we can't assume custom images have this binary. |
Today if you run Anyone who's hacking on postgres-flex is likely to have the
|
I'm don't think we should remove the FLY_DEV check, but i'm cool opening up the |
For the record, this changes |
This reverts commit 3b6734c.
This is relevant in development - e.g. if you run
fly deploy -a <my-db>
in postgres-flex