-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flyctl support for scanning images with scantron #3725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code and awesome functionality. Maybe instead of asking people to download your branch to run this, we could just hide the registry
subcommand and temporarily ship it as a hidden feature.
- fetch images concurrently - prefer sets (maps) over lists for performance and clarity
- Allow flaps client without AppCompact by passing OrgSlug. - Refactor code to skip looking up AppCompact and use OrgSlug instead when scanning all apps in an org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this and ask folks to kick the tires
One more thing I just noticed is that the registry returns the same response for
When scantron gets that response, it returns a 500. Flyctl should probably collect these errors and report them, but not fail the whole vulnsummary command. |
I also got a 400 scanning another org with this log line in scantron
|
…en if some image scan fetches fail.
Change Summary
What and Why: Add support for fetching SBOMs and vuln scans from scantron and presenting them to the user. This allows users to quickly determine if they may be affected by security issues.
How: add new commands "scan sbom" and "scan vulns", which query scantron fro sboms and scan data, and present them to the user.
Related to: scantron
Documentation