refactor: rename keys to storage key in storage ref helper

superhero-com · Oct 4, 2023 · e255040 · e255040
1 parent 02665a8
commit e255040
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/composables/accounts.ts b/src/composables/accounts.ts
@@ -177,8 +177,8 @@ export function useAccounts() {
     }
   }
 
-  function setMnemonic(val: string) {
-    mnemonic.value = val;
+  function setMnemonic(newMnemonic: string) {
+    mnemonic.value = newMnemonic;
   }
 
   function setGeneratedMnemonic() {

diff --git a/src/composables/composablesHelpers.ts b/src/composables/composablesHelpers.ts
@@ -33,7 +33,7 @@ interface ICreateStorageRefOptions<T> {
  */
 export function useStorageRef<T = string | object | any[]>(
   initialState: T,
-  keys: StorageKey,
+  storageKey: StorageKey,
   options: ICreateStorageRefOptions<T> = {},
 ) {
   const {
@@ -56,7 +56,7 @@ export function useStorageRef<T = string | object | any[]>(
   watch(state, (val, oldVal) => {
     // Arrays are not compared as there is a bug which makes the new and old val always the same.
     if (!watcherDisabled && (Array.isArray(initialState) || !isEqual(val, oldVal))) {
-      WalletStorage.set(keys, (serializer?.write) ? serializer.write(val) : val);
+      WalletStorage.set(storageKey, (serializer?.write) ? serializer.write(val) : val);
     }
   }, { deep: true });
 
@@ -66,12 +66,12 @@ export function useStorageRef<T = string | object | any[]>(
    * and synchronizes own state with the change.
    */
   if (backgroundSync) {
-    WalletStorage.watch?.(keys, (val) => setState(val));
+    WalletStorage.watch?.(storageKey, (val) => setState(val));
   }
 
   if (!isRestored) {
     (async () => {
-      const restoredValue = await WalletStorage.get<T | null>(keys);
+      const restoredValue = await WalletStorage.get<T | null>(storageKey);
       setState(restoredValue);
       isRestored = true;
     })();

diff --git a/src/composables/transactionTx.ts b/src/composables/transactionTx.ts
@@ -1,6 +1,7 @@
 import { computed, ref } from 'vue';
 import { Encoded, Tag } from '@aeternity/aepp-sdk';
 import type {
+  IAccountOverview,
   IDefaultComposableOptions,
   ITokenList,
   ITx,
@@ -172,7 +173,7 @@ export function useTransactionTx({
     ownerAddress.value = address;
   }
 
-  function getOwnershipAccount(externalOwnerAddress?: Encoded.AccountAddress): any {
+  function getOwnershipAccount(externalOwnerAddress?: Encoded.AccountAddress): IAccountOverview {
     switch (ownershipStatus.value) {
       case AE_TRANSACTION_OWNERSHIP_STATUS.current:
         return activeAccount.value;
@@ -187,7 +188,7 @@ export function useTransactionTx({
         return {
           name: getPreferredName.value(address) || '',
           address,
-        } as any; // TODO establish the required return type for the function
+        };
       }
     }
   }