Move vuex hdWallet methods to SDK wallet lib #2409

peronczyk · 2023-10-18T12:27:33Z

No description provided.

src/composables/permissions.ts

github-actions · 2023-10-24T20:57:36Z

Deployed to refactor-move-vuex-hdwallet-methods-to-sdk-wallet-lib.wallet.z52da5wt.xyz, artifacts

peronczyk · 2023-10-25T06:14:23Z

src/background/popupHandler.ts

+        message: params.message,
+        tx: params.tx,
+        txBase64: params.txBase64,


Previously the Raw Sign modal was receiving the props in a different format than the regular sign modal. I aligned both modals as they both are using the PopupProps composable. Now the structure is enforced by the TypeScript - less possible to make a mistake.

peronczyk · 2023-10-25T07:51:24Z

src/composables/permissions.ts

+      if (
+        method === METHODS.sign
+        && (!modalProps.txBase64 || !isTxOfASupportedType(modalProps.txBase64))
+      ) {
+        modal = MODAL_CONFIRM_RAW_SIGN;
+        popup = POPUP_TYPE_RAW_SIGN;
+      }


Previously the openPopup was detecting if the transaction is supported by the app or not. The same check was done in the previous permissions Vuex module. So there was 2 places doing the same logic. I consolidated this and moved here as the permissions composable is the only place where the openPopup function is fired.

peronczyk · 2023-10-25T07:53:54Z

src/popup/components/Modals/ConfirmRawSign.vue

-        ? popupProps.value?.data
-        : Buffer.from(popupProps.value?.data as any).toString('hex'),
-    );
+    const dataAsString = computed((): string => popupProps.value?.txBase64?.toString() || '');


As there is no such a thing as data anymore we were able to skip any conditional checks.

peronczyk · 2023-10-25T07:59:25Z

src/protocols/aeternity/libs/AeAccountHdWallet.ts

This is the most important file of the PR. It consists all the logic we had in the Vuex hdWallet module. So this is a core of signing stuff and asking user for permission to do it.
Following methods does not exist anymore:

signTransactionWithoutConfirmation - calculating if the confirmation modal should be open is now done in a different way.

signTransactionFromAccount - passing fromAccount as one of the properties of any of the default sign method options causes to sign with the specified account.

This class looks good 👍

src/protocols/aeternity/libs/AeAccountHdWallet.ts

Liubov-crypto · 2023-10-26T14:17:44Z

During my testing I've constantly got this issue in console, and I think it might be affect all errors that I listed below:

Error: pubkey cannot be null or undefined.

Can't send ae and Fungible tokens:
Verify an amount and Max button isn't working for FT:

2023-10-26.4.40.34.mov

Set name pointer:
Register a name:
Multisig creation
Generate Gift card
Bid on name
Transactions on DEX:
Interactions with superhero.com - I can connect my wallet but there is no popup for signing Txs.

@peronczyk please check it.

peronczyk · 2023-10-31T08:41:05Z

@Liubov-crypto thank you for your comments. I addressed your feedback. Please retest.

src/popup/pages/SeedPhraseVerifySettings.vue

src/protocols/aeternity/libs/AeAccountHdWallet.ts

martinkaintas

lgtm

CedrikNikita

Code changes look reasonable.

src/protocols/aeternity/libs/AeAccountHdWallet.ts

subhod-i · 2023-11-09T17:11:20Z

Code changes looks good to me. Apart of that please fix the bugs we discussed.

subhod-i

Cool PR.

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch 2 times, most recently from 46c8d5e to ac7abc6 Compare October 18, 2023 13:02

peronczyk force-pushed the refactor/move-permissions-vuex-state-to-composable branch 2 times, most recently from 5853684 to 917b518 Compare October 20, 2023 06:25

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from ac7abc6 to 1e9d4ec Compare October 20, 2023 06:26

peronczyk force-pushed the refactor/move-permissions-vuex-state-to-composable branch from 917b518 to 358a241 Compare October 23, 2023 07:15

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from 1e9d4ec to d445277 Compare October 23, 2023 07:19

peronczyk force-pushed the refactor/move-permissions-vuex-state-to-composable branch 2 times, most recently from df4c5e8 to 53cae92 Compare October 23, 2023 10:43

Base automatically changed from refactor/move-permissions-vuex-state-to-composable to develop October 23, 2023 11:12

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from d445277 to 21e1e69 Compare October 23, 2023 11:22

github-advanced-security bot found potential problems Oct 23, 2023

View reviewed changes

src/composables/permissions.ts Fixed Show fixed Hide fixed

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch 4 times, most recently from ae128c4 to d2f6c8b Compare October 24, 2023 20:39

peronczyk marked this pull request as ready for review October 24, 2023 20:58

peronczyk changed the title ~~[DRAFT] Move vuex hdWallet methods to SDK wallet lib~~ Move vuex hdWallet methods to SDK wallet lib Oct 24, 2023

peronczyk linked an issue Oct 24, 2023 that may be closed by this pull request

Move the account signing methods from Vuex to composable #2425

Closed

peronczyk requested review from subhod-i, CedrikNikita and martinkaintas October 24, 2023 20:59

peronczyk commented Oct 25, 2023

View reviewed changes

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch 3 times, most recently from 1c1631d to 21b67d8 Compare October 25, 2023 07:50

peronczyk commented Oct 25, 2023

View reviewed changes

martinkaintas reviewed Oct 25, 2023

View reviewed changes

src/protocols/aeternity/libs/AeAccountHdWallet.ts Outdated Show resolved Hide resolved

CedrikNikita mentioned this pull request Oct 26, 2023

[SW-1298] move fungibleTokens from store to composable #2361

Merged

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch 3 times, most recently from cadb511 to f0f4087 Compare October 26, 2023 09:00

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch 2 times, most recently from 1a2d0e8 to 8ca035f Compare October 31, 2023 07:49

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch 3 times, most recently from 84a1f80 to a4882aa Compare November 2, 2023 12:09

peronczyk self-assigned this Nov 3, 2023

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from a4882aa to fc4876a Compare November 6, 2023 10:43

peronczyk requested a review from martinkaintas November 6, 2023 13:30

martinkaintas reviewed Nov 6, 2023

View reviewed changes

src/popup/pages/SeedPhraseVerifySettings.vue Outdated Show resolved Hide resolved

martinkaintas reviewed Nov 6, 2023

View reviewed changes

src/protocols/aeternity/libs/AeAccountHdWallet.ts Outdated Show resolved Hide resolved

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from fc4876a to 813a18a Compare November 6, 2023 13:51

martinkaintas approved these changes Nov 6, 2023

View reviewed changes

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from 813a18a to 5b6f1be Compare November 6, 2023 13:53

CedrikNikita approved these changes Nov 9, 2023

View reviewed changes

subhod-i reviewed Nov 9, 2023

View reviewed changes

src/protocols/aeternity/libs/AeAccountHdWallet.ts Outdated Show resolved Hide resolved

src/protocols/aeternity/libs/AeAccountHdWallet.ts Show resolved Hide resolved

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from 5b6f1be to c72d3d7 Compare November 10, 2023 07:48

refactor: move vuex hdwallet methods to sdk wallet lib

077e957

peronczyk force-pushed the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch from c72d3d7 to 077e957 Compare November 10, 2023 08:16

subhod-i approved these changes Nov 10, 2023

View reviewed changes

peronczyk merged commit 7c3cb65 into develop Nov 10, 2023
4 checks passed

peronczyk deleted the refactor/move-vuex-hdwallet-methods-to-sdk-wallet-lib branch November 10, 2023 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move vuex hdWallet methods to SDK wallet lib #2409

Move vuex hdWallet methods to SDK wallet lib #2409

peronczyk commented Oct 18, 2023

github-actions bot commented Oct 24, 2023

peronczyk Oct 25, 2023

peronczyk Oct 25, 2023

peronczyk Oct 25, 2023

peronczyk Oct 25, 2023 •

edited

Loading

davidyuk Oct 27, 2023 •

edited

Loading

Liubov-crypto commented Oct 26, 2023

peronczyk commented Oct 31, 2023

martinkaintas left a comment

CedrikNikita left a comment

subhod-i commented Nov 9, 2023

subhod-i left a comment

Move vuex hdWallet methods to SDK wallet lib #2409

Move vuex hdWallet methods to SDK wallet lib #2409

Conversation

peronczyk commented Oct 18, 2023

github-actions bot commented Oct 24, 2023

peronczyk Oct 25, 2023

Choose a reason for hiding this comment

peronczyk Oct 25, 2023

Choose a reason for hiding this comment

peronczyk Oct 25, 2023

Choose a reason for hiding this comment

peronczyk Oct 25, 2023 • edited Loading

Choose a reason for hiding this comment

davidyuk Oct 27, 2023 • edited Loading

Choose a reason for hiding this comment

Liubov-crypto commented Oct 26, 2023

peronczyk commented Oct 31, 2023

martinkaintas left a comment

Choose a reason for hiding this comment

CedrikNikita left a comment

Choose a reason for hiding this comment

subhod-i commented Nov 9, 2023

subhod-i left a comment

Choose a reason for hiding this comment

peronczyk Oct 25, 2023 •

edited

Loading

davidyuk Oct 27, 2023 •

edited

Loading