Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forget Password flow #18

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Forget Password flow #18

merged 2 commits into from
Mar 22, 2021

Conversation

jianga
Copy link

@jianga jianga commented Mar 19, 2021 •
edited
Loading

Added forget password to login screen.

@jianga jianga linked an issue Mar 19, 2021 that may be closed by this pull request
Implement password reset #1
Closed
@jianga jianga added the enhancement New feature or request label Mar 21, 2021
@jianga jianga requested a review from styu March 21, 2021 03:12
styu
styu reviewed Mar 21, 2021
View reviewed changes
Copy link

@styu styu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my edification where is the code that does the emailing?

puzzle_editing/templates/reset_password_confirm.html Outdated Show resolved Hide resolved
@jianga @styu
Update puzzle_editing/templates/reset_password_confirm.html
8f5beff 
Co-authored-by: styu <styu314@gmail.com>
@jianga
Copy link
Author

jianga commented Mar 22, 2021

for my edification where is the code that does the emailing?

Django magic that I don't completely understand :) There are some built-in auth views that are super convenient to use: https://docs.djangoproject.com/en/3.1/topics/auth/default/#built-in-auth-views

@jianga jianga merged commit c9dc1f6 into master Mar 22, 2021
@jianga jianga deleted the forget_password branch March 22, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styu styu styu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement password reset
2 participants
@jianga @styu