[SuperTextField][iOS] Increase drag handle interaction area (Resolves #1926) #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-carroll
deleted the
1926_update-ios-textfield-handle-interaction-area
branch
matthew-carroll
pushed a commit
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperTextField][iOS] Increase drag handle interaction area. Resolves #1926
Our iOS text field has a small interaction area (24px wide). Looking at the SuperEditor implementation, it looks like we are already using 48px wide. Also, the textfield caret already seems to have a 48px wide interaction area.
The expanded handle ball radius was already increased in a previous PR.
This PR only changes the width of the interaction area of the expanded handles to 48px, as it was mentioned that this was the width Flutter textfield uses.