Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotate the geometry instead of mesh to work with teleport component #21

Merged

Conversation

vincentfretin
Copy link
Contributor

We can now teleport on the hills!
The changes here is needed so the intersect face normal of raycaster is valid for the teleport component, i.e a vector x: 0, y: 1, z: 0 instead of x: 0, y: 0, z: 1.

There is a similar fix in fernandojsg/aframe-teleport-controls#29

@vincentfretin
Copy link
Contributor Author

vincentfretin commented Oct 1, 2017

Ah I forgot, if you want to test teleport on the hills, use the environmentGround class that was added to the ground entity in master:

        <a-entity id="cameraRig">
          <a-camera />
          <a-entity
            class="right-controller"
            teleport-controls="cameraRig: #cameraRig; maxLength: 200; type: line; collisionEntities: .environmentGround, .environmentDressing"
            gearvr-controls
          />
        </a-entity>

@vincentfretin
Copy link
Contributor Author

vincentfretin commented Oct 1, 2017

I'm using this environment <a-entity environment="ground: canyon; groundYScale: 10; groundTexture: squares; dressing: mushrooms; dressingScale: 10; dressingAmount: 20" /> for my tests.

Hum, I want to teleport on mushrooms now. We need a class, maybe add a class dressing to generated objects, what do you think?

@vincentfretin
Copy link
Contributor Author

vincentfretin commented Oct 1, 2017

I added a commit to add a environmentDressing class to the dressing meshs.
I edited collisionEntities above to add .environmentDressing.
So much fun! ;-)

@vincentfretin
Copy link
Contributor Author

I added a paragraph about aframe-environment-component in my fernandojsg/aframe-teleport-controls#28 PR

@vincentfretin
Copy link
Contributor Author

You can currently test it on my sandbox repository https://github.com/vincentfretin/aframe-sandbox which includes a link to a built version. @ngokevin you may be interested in my working version of hot reloading, see the README.

@feiss
Copy link
Contributor

feiss commented Oct 4, 2017

This is nice, thank you very much! 👍

@feiss
Copy link
Contributor

feiss commented Oct 7, 2017

Sorry, I have to revert this PR due to #22 . I'll give it a second check. Thanks anyway!

@vincentfretin
Copy link
Contributor Author

No worries. If you can take the time to find the issue, I'll gladly appreciate it.

@vincentfretin
Copy link
Contributor Author

@feiss With https://github.com/feiss/aframe-environment-component/pull/24 I don't manage to enable the physics and have this fix for teleport. I think I will take a different approach and modify the isValidNormalsAngle method in the teleport component to take into account the meshs rotation.
So don't bother to look into it.

PiTiLeZarD pushed a commit to PiTiLeZarD/aframe-environment-component-v2 that referenced this pull request May 11, 2022
…rated-ground

rotate the geometry instead of mesh to work with teleport component
PiTiLeZarD pushed a commit to PiTiLeZarD/aframe-environment-component-v2 that referenced this pull request May 11, 2022
…rated-ground

rotate the geometry instead of mesh to work with teleport component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants