-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cool internal perimeters as external. #3415
Conversation
can you please create two sliced files with and without this feature added and compare the two outputs |
you'll need to run alot more checks than that (a model that will use all extrusion roles) . the placeholder "_EXTERNAL_PERIMETER" is used in the speed slowdown part. the above looks for any line that contains the placeholder "_EXTERNAL_PERIMETER" and makes the var "external_perimeter " true. i'm currently working on adding cooling options for all extrusion roles.(90% completed ) |
Well, if someone want to cool all perimeters slowdown can be useful. But it's possible to use something like _PERIMETER for cooling if Merill would like this PR in general. |
@legend069, could you also add fan speed to modifier block? |
f8c9106
to
eb55d83
Compare
oh right that thing. i'll certainly have a look though the code. if it won't take much time i'll add it. |
Will be included in another PR. |
. now easier to add new control and do complicate stuff in the cooling buffer. . less overall number of lines of code for better results. . add 6 new fan control. . now if the disable_fan_first_layers is at 0 and full_fan_speed_layer at more than 1, the first layer has some fan speed. . updated fan speeds that cannot be increased even with low layer time (top solid, ironing, support, support interface) . updated fan speeds that cannot be reduced by full_fan_speed_layer (bridge, infill bridge, overhangs, support interface) . updated extrusion speed that can't be reduced (overhang, bridge) . updated extrusion speed that shouldn't be reduced if possible (external, ironing, infill bridge, thin wall, support interface) . better name for CoolingBuffer::process_layer variables #3735 #3608 #3568 #3415 #3408 #3380 #3367 #3361 #3271 #3152 #2872 #2696 #2419 #2326
. now easier to add new control and do complicate stuff in the cooling buffer. . less overall number of lines of code for better results. . add 6 new fan control. . now if the disable_fan_first_layers is at 0 and full_fan_speed_layer at more than 1, the first layer has some fan speed. . updated fan speeds that cannot be increased even with low layer time (top solid, ironing, support, support interface) . updated fan speeds that cannot be reduced by full_fan_speed_layer (bridge, infill bridge, overhangs, support interface) . updated extrusion speed that can't be reduced (overhang, bridge) . updated extrusion speed that shouldn't be reduced if possible (external, ironing, infill bridge, thin wall, support interface) . better name for CoolingBuffer::process_layer variables supermerill#3735 supermerill#3608 supermerill#3568 supermerill#3415 supermerill#3408 supermerill#3380 supermerill#3367 supermerill#3361 supermerill#3271 supermerill#3152 supermerill#2872 supermerill#2696 supermerill#2419 supermerill#2326
PR for #3408
It could further improve model stability in case when infill not cooled.