Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cool internal perimeters as external. #3415

Closed
wants to merge 8 commits into from
Closed

Cool internal perimeters as external. #3415

wants to merge 8 commits into from

Conversation

vovodroid
Copy link

PR for #3408

It could further improve model stability in case when infill not cooled.

image

image

@legend069
Copy link

can you please create two sliced files with and without this feature added and compare the two outputs
adding another comment for "_EXTERNAL_PERIMETER" will mess with other things.
ie; coolingbuffer.cpp

@vovodroid
Copy link
Author

vovodroid commented Nov 30, 2022

Attached gcode files without and with this option.
External only:
image

All perimeters:
image

Cooling_gcode.zip

@legend069
Copy link

you'll need to run alot more checks than that (a model that will use all extrusion roles) . the placeholder "_EXTERNAL_PERIMETER" is used in the speed slowdown part.
example:
bool external_perimeter = boost::contains(sline, ";_EXTERNAL_PERIMETER");

the above looks for any line that contains the placeholder "_EXTERNAL_PERIMETER" and makes the var "external_perimeter " true.

i'm currently working on adding cooling options for all extrusion roles.(90% completed )
in my checks i used to get different values when slowdown layer time thing started.(alternating solid infill patterns and ect.

@vovodroid
Copy link
Author

the placeholder "_EXTERNAL_PERIMETER" is used in the speed slowdown part.

Well, if someone want to cool all perimeters slowdown can be useful. But it's possible to use something like _PERIMETER for cooling if Merill would like this PR in general.

@vovodroid
Copy link
Author

i'm currently working on adding cooling options for all extrusion roles.(90% completed )

@legend069, could you also add fan speed to modifier block?

@legend069
Copy link

you also

what do you mean "fan speed modifier block" ?
i've attached picture on the new cooling options.

image

@vovodroid
Copy link
Author

what do you mean "fan speed modifier block" ?

I mean adding fan speed for "Add modifier":

image

@legend069
Copy link

legend069 commented Jan 17, 2023

what do you mean "fan speed modifier block" ?

I mean adding fan speed for "Add modifier":

oh right that thing. i'll certainly have a look though the code. if it won't take much time i'll add it.
but i'll assume it won't be easy so that feature might need to be done at another time.

@vovodroid
Copy link
Author

Will be included in another PR.

@vovodroid vovodroid closed this Mar 24, 2023
@vovodroid vovodroid deleted the coool_internal_perimeter_as_external branch March 24, 2023 17:01
supermerill added a commit that referenced this pull request Nov 14, 2023
 . now easier to add new control and do complicate stuff in the cooling buffer.
 . less overall number of lines of code for better results.
 . add 6 new fan control.
 . now if the disable_fan_first_layers is at 0 and full_fan_speed_layer at more than 1, the first layer has some fan speed.
 . updated fan speeds that cannot be increased even with low layer time (top solid, ironing, support, support interface)
 . updated fan speeds that cannot be reduced by full_fan_speed_layer (bridge, infill bridge, overhangs, support interface)
 . updated extrusion speed that can't be reduced (overhang, bridge)
 . updated extrusion speed that shouldn't be reduced if possible (external, ironing, infill bridge, thin wall, support interface)
 . better name for CoolingBuffer::process_layer variables

#3735
#3608
#3568
#3415
#3408
#3380
#3367
#3361
#3271
#3152
#2872
#2696
#2419
#2326
legend069 pushed a commit to legend069/SuperSlicer that referenced this pull request Nov 19, 2023
 . now easier to add new control and do complicate stuff in the cooling buffer.
 . less overall number of lines of code for better results.
 . add 6 new fan control.
 . now if the disable_fan_first_layers is at 0 and full_fan_speed_layer at more than 1, the first layer has some fan speed.
 . updated fan speeds that cannot be increased even with low layer time (top solid, ironing, support, support interface)
 . updated fan speeds that cannot be reduced by full_fan_speed_layer (bridge, infill bridge, overhangs, support interface)
 . updated extrusion speed that can't be reduced (overhang, bridge)
 . updated extrusion speed that shouldn't be reduced if possible (external, ironing, infill bridge, thin wall, support interface)
 . better name for CoolingBuffer::process_layer variables

supermerill#3735
supermerill#3608
supermerill#3568
supermerill#3415
supermerill#3408
supermerill#3380
supermerill#3367
supermerill#3361
supermerill#3271
supermerill#3152
supermerill#2872
supermerill#2696
supermerill#2419
supermerill#2326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants