Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] log worker startup counts #2958

Merged
merged 3 commits into from
Jun 3, 2024
Merged

[feature] log worker startup counts #2958

merged 3 commits into from
Jun 3, 2024

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

Logs the number of each worker kind started during init. As pointed out by @daenney the way we were doing it previously was overly verbose and kinda useless, so moving to debug logging was definitely an improvement, but this removes the per-worker logging and instead just uses simple per-worker-pool-type n-workers-started style logging

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

daenney
daenney approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@daenney daenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems much more useful 😄.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit f17dd62 into superseriousbusiness:main Jun 3, 2024
2 checks passed
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@NyaaaWhatsUpDoc @nyarla
[feature] log worker startup counts (superseriousbusiness#2958)
c48ebf2 
* log number of each worker kinds started, and log when stopped

* remove worker debug logging

* whoops, fix the count of media workers
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@NyaaaWhatsUpDoc @nyarla
[feature] log worker startup counts (superseriousbusiness#2958)
5cddbc3 
* log number of each worker kinds started, and log when stopped

* remove worker debug logging

* whoops, fix the count of media workers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daenney daenney daenney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NyaaaWhatsUpDoc @daenney