Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix slice init length #3382

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Oct 3, 2024

Description

The intention here should be to initialize a slice with a capacity of diff rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

thanks for the contribution! before merge can you go through confirm some of our checklist boxes please? :)

@cuishuang cuishuang changed the title fix: fix slice init length [bugfix]: fix slice init length Oct 3, 2024
@cuishuang cuishuang changed the title [bugfix]: fix slice init length [bugfix] fix slice init length Oct 3, 2024
@cuishuang
Copy link
Contributor Author

thanks for the contribution! before merge can you go through confirm some of our checklist boxes please? :)

Thanks. Modified.

@cuishuang
Copy link
Contributor Author

I think the change is minor and the issues fixed are very clear according to the online demo: https://go.dev/play/p/q1BcVCmvidW

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 23b6d2c into superseriousbusiness:main Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants