Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Adgeneration to add NovatiqSystem. #4

Merged
merged 4 commits into from
Mar 14, 2022
Merged

update Adgeneration to add NovatiqSystem. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bbd268
update Adgeneration to add NovatiqSystem.
banakemi Mar 11, 2022
8a44228
Add IOS check
banakemi Mar 14, 2022
5ca58f6
update adapter version
banakemi Mar 14, 2022
e0ab608
fix novatiq object
banakemi Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion modules/adgenerationBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const spec = {
* @return ServerRequest Info describing the request to the server.
*/
buildRequests: function (validBidRequests, bidderRequest) {
const ADGENE_PREBID_VERSION = '1.2.0';
const ADGENE_PREBID_VERSION = '1.3.0';
let serverRequests = [];
for (let i = 0, len = validBidRequests.length; i < len; i++) {
const validReq = validBidRequests[i];
Expand All @@ -50,6 +50,12 @@ export const spec = {
data = tryAppendQueryString(data, 'imark', '1');
}
data = tryAppendQueryString(data, 'tp', bidderRequest.refererInfo.referer);
if (isIos()) {
const hyperId = getHyperId(validReq);
if (hyperId != null) {
data = tryAppendQueryString(data, 'hyper_id', hyperId);
}
}
// remove the trailing "&"
if (data.lastIndexOf('&') === data.length - 1) {
data = data.substring(0, data.length - 1);
Expand Down Expand Up @@ -263,4 +269,20 @@ function getCurrencyType() {
return 'JPY';
}

/**
*
* @param validReq request
* @return {null|string}
*/
function getHyperId(validReq) {
if (validReq.userId && validReq.userId.novatiq && validReq.userId.novatiq.snowflake.syncResponse === 1) {
return validReq.userId.novatiq.snowflake.id;
}
return null;
}

function isIos() {
return (/(ios|ipod|ipad|iphone)/i).test(window.navigator.userAgent);
}

registerBidder(spec);
42 changes: 39 additions & 3 deletions test/spec/modules/adgenerationBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,23 @@ describe('AdgenerationAdapter', function () {
bidderRequestId: '14a9f773e30243',
auctionId: '4aae9f05-18c6-4fcd-80cf-282708cd584a',
transactionTd: 'f76f6dfd-d64f-4645-a29f-682bac7f431a'
},
{ // bannerWithHyperId
bidder: 'adg',
params: {
id: '58278', // banner
},
adUnitCode: 'adunit-code',
sizes: [[320, 100]],
bidId: '2f6ac468a9c15e',
bidderRequestId: '14a9f773e30243',
auctionId: '4aae9f05-18c6-4fcd-80cf-282708cd584a',
transactionTd: 'f76f6dfd-d64f-4645-a29f-682bac7f431a',
userId: {
novatiq: {
snowflake: {'id': 'novatiqId', syncResponse: 1}
}
}
}
];
const bidderRequest = {
Expand All @@ -92,9 +109,10 @@ describe('AdgenerationAdapter', function () {
}
};
const data = {
banner: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.2.0&imark=1&tp=https%3A%2F%2Fexample.com`,
bannerUSD: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=USD&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.2.0&imark=1&tp=https%3A%2F%2Fexample.com`,
native: 'posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=1x1&currency=JPY&pbver=' + prebid.version + '&sdkname=prebidjs&adapterver=1.2.0&tp=https%3A%2F%2Fexample.com'
banner: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.3.0&imark=1&tp=https%3A%2F%2Fexample.com`,
bannerUSD: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=USD&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.3.0&imark=1&tp=https%3A%2F%2Fexample.com`,
native: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=1x1&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.3.0&tp=https%3A%2F%2Fexample.com`,
bannerWithHyperId: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.3.0&imark=1&tp=https%3A%2F%2Fexample.com&hyper_id=novatiqId`,
};
it('sends bid request to ENDPOINT via GET', function () {
const request = spec.buildRequests(bidRequests, bidderRequest)[0];
Expand All @@ -118,6 +136,19 @@ describe('AdgenerationAdapter', function () {
const request = spec.buildRequests(bidRequests, bidderRequest)[1];
expect(request.data).to.equal(data.native);
});

it('should attache params to the bannerWithHyperId request', function () {
const defaultUA = window.navigator.userAgent;
window.navigator.__defineGetter__('userAgent', function() {
return 'Mozilla/5.0 (iPhone; CPU iPhone OS 14_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Mobile/15E148 Safari/604.1';
});
const request = spec.buildRequests(bidRequests, bidderRequest)[2];

window.navigator.__defineGetter__('userAgent', function() {
return defaultUA;
});
expect(request.data).to.equal(data.bannerWithHyperId);
});
it('allows setConfig to set bidder currency for JPY', function () {
config.setConfig({
currency: {
Expand Down Expand Up @@ -797,6 +828,11 @@ describe('AdgenerationAdapter', function () {
});

it('handles ADGBrowserM responses', function () {
config.setConfig({
currency: {
adServerCurrency: 'JPY'
}
});
const result = spec.interpretResponse({body: serverResponse.normal.upperBillboard}, bidRequests.upperBillboard)[0];
expect(result.requestId).to.equal(bidResponses.normal.upperBillboard.requestId);
expect(result.width).to.equal(bidResponses.normal.upperBillboard.width);
Expand Down