Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render on demand #2

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Render on demand #2

merged 2 commits into from
Mar 29, 2024

Conversation

superstar54
Copy link
Owner

@superstar54 superstar54 commented Mar 29, 2024 •
edited
Loading

fix superstar54/weas-widget#48, superstar54/weas-widget#49

  • Remove the animation loop
  • Call the render function only on certain events (user interaction, window resizing, drawing new models, etc.)
  • Add test for measurement

@superstar54 superstar54 merged commit 9a7dd24 into main Mar 29, 2024
8 checks passed
@superstar54 superstar54 mentioned this pull request Mar 29, 2024
Closed
@superstar54 superstar54 deleted the render_on_demand branch March 29, 2024 06:09
@superstar54 superstar54 mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

100% CPU when running widget in VSCode
1 participant
@superstar54