Add routing to dashboard and create a basic Auth page #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkshah2
suggested changes
Jul 10, 2022
src/components/pages/Auth/Auth.tsx
Outdated
Comment on lines
45
to
46
| <h2>Log in to Dashboard</h2> | ||
| <button onClick={promptForApiKey}>Insert your API Key</button> |
There was a problem hiding this comment.
We dont need to have any user interaction here, on page open just show them an alert or something with an input in it
src/components/pages/Auth/Auth.tsx
Outdated
| const apiKey = prompt("Please enter your API key"); | ||
| if (apiKey !== null && apiKey.length !== 0) { | ||
| setValueToStorage(apiKeyLocalStorageKey, apiKey); | ||
| setApiKey(apiKey); |
There was a problem hiding this comment.
Not needed anymore, it was needed for redirection
Comment on lines
16
to
39
| import React, { useEffect } from "react"; | ||
| import { Navigate, Outlet } from "react-router-dom"; | ||
|
|
||
| import { apiKeyLocalStorageKey } from "../../../constants"; | ||
| import { getValueFromStorage } from "../../../storageService"; | ||
|
|
||
| const ProtectedRoute = () => { | ||
| const [shouldRedirect, setShouldRedirect] = React.useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const apiKey = getValueFromStorage(apiKeyLocalStorageKey); | ||
| if (apiKey === null || apiKey.length === 0) { | ||
| setShouldRedirect(true); | ||
| } | ||
| }, []); | ||
|
|
||
| if (shouldRedirect) { | ||
| return <><Navigate to="/" /></>; | ||
| } | ||
|
|
||
| return <Outlet />; | ||
| }; | ||
|
|
||
| export default ProtectedRoute; |
There was a problem hiding this comment.
Just have an HOC that checks for the API key and renders a child if its found or redirects to "/" if it doesnt. Dont rely this heavily on the router
|
|
||
| // return to dashboard home once apiKey is stored in localStorage | ||
| if (apiKey.length > 0) { | ||
| return <Navigate to="/home" /> |
There was a problem hiding this comment.
Just use window API please
src/index.tsx
Outdated
| root.render( | ||
| <React.StrictMode> | ||
| <App /> | ||
| <BrowserRouter basename="/auth/dashboard"> |
|
Closing due to #3 |
nkshah2
added a commit
that referenced
this pull request
Sep 1, 2023
fix: dropdown flicker on user list #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
react-router-domAuthcomponent served on<apiBasePath>/dashboardrouteapiKeyvalue from LocalStorageapiKey<apiBasePath>/dashboard/homeapiKeyvalue is not present in localStorage<apiBasePath>/dashboard/home