Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix hardcoded auth mode #43

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix: Fix hardcoded auth mode #43

merged 3 commits into from
Sep 15, 2023

Conversation

nkshah2
Copy link
Contributor

@nkshah2 nkshah2 commented Sep 15, 2023

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/src/version.dart
  • Changes to the version if needed
    • In pubspec.yaml
    • In lib/src/version.dart
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • ...

CHANGELOG.md Outdated
Comment on lines 9 to 11
## [0.2.9] - 2023-09-13

- Fixes an issue where requests to the refresh endpoint would always send auth mode as cookies in the headers for http
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove version change

@rishabhpoddar rishabhpoddar merged commit 7491f4a into 0.2 Sep 15, 2023
3 checks passed
@rishabhpoddar rishabhpoddar deleted the fix-hardcoded-auth-mode branch September 15, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants