Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with dashboard throwing an error when updating the user's password #312

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

nkshah2
Copy link
Contributor

@nkshah2 nkshah2 commented Jul 26, 2023

Summary of change

  • Fixes an issue where updating a user's password from the dashboard would result in a pointer exception when using the thirdpartyemailpassword recipe (Also applied the fix when updating the user's email)
  • Adds tests for userPasswordPut and userPut APIs to verify the fix

Related issues

Test Plan

Added new tests

Documentation changes

NA

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • ...

…using the thirdpartyemailpassword recipe to update a user's email or password instead of using the normalised config of thirdpartyemailpassword directly
@rishabhpoddar rishabhpoddar merged commit efa8a47 into 0.12 Jul 26, 2023
4 of 5 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/dashboard-update-password branch July 26, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants