Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitlab and bitbucket impl #327

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix: gitlab and bitbucket impl #327

merged 3 commits into from
Aug 3, 2023

Conversation

sattvikc
Copy link
Collaborator

@sattvikc sattvikc commented Aug 3, 2023

Summary of change

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@sattvikc sattvikc self-assigned this Aug 3, 2023
@sattvikc sattvikc changed the title Provider fixes fix: gitlab and bitbucket impl Aug 3, 2023
@sattvikc sattvikc merged commit e2d7ab4 into feat/tp-rework Aug 3, 2023
4 of 8 checks passed
@sattvikc sattvikc deleted the provider-fixes branch August 3, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant