Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #97

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix: typo #97

merged 1 commit into from
Feb 9, 2024

Conversation

sattvikc
Copy link
Collaborator

@sattvikc sattvikc commented Feb 9, 2024

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • Item1
  • Item2

@sattvikc sattvikc self-assigned this Feb 9, 2024
@rishabhpoddar rishabhpoddar merged commit 78a5148 into 5.0 Feb 9, 2024
1 of 3 checks passed
@rishabhpoddar rishabhpoddar deleted the typo branch February 9, 2024 18:37
sattvikc added a commit that referenced this pull request Mar 11, 2024
* fix: remove db password from logs (#89)

* fix: remove db password from logs

* fix: mask db password

* fix: Add tests

* fix: Add more tests

* fix: PR changes

* fix: tests for connection pool (#90)

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: cicd tests (#92)

* fix: logging test (#93)

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: flaky test (#94)

* fix: make connection pool test less flaky

* fix: test

* fix: typo

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: adds idle timeout and minimum idle configs (#95)

* fix: idle connection configs

* test: protected configs

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: cicd (#96)

* fix: cicd

* fix: test

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: typo (#97)

* adding dev-v5.0.6 tag to this commit to ensure building

* fixes tests

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: Vulnerability fix (#98)

* fix: updated dependencies

* chore: version and changelog

* fix: versions

* adding dev-v5.0.7 tag to this commit to ensure building

* fix: dependencies (#101)

* fix: dependency fix

* fix: dep fix

* adding dev-v5.0.7 tag to this commit to ensure building

* fix: fixes storage handling for non-auth recipes (#102)

* fix: non-auth fix

* fix: migration script and test fixes

* fix: plugin interface version

* fix: remove unnecessary func

* adding dev-v6.0.0 tag to this commit to ensure building

---------

Co-authored-by: Ankit Tiwari <ankucodes@gmail.com>
Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com>
rishabhpoddar added a commit that referenced this pull request Mar 13, 2024
* fix: mfa and totp updates

* fix: queries

* fix: misc fixes (#80)

* fix: mfa

* fix: queries

* fix: queries

* fix: mfa changes (#87)

* feat: Add support to update the signing key type of a session (#88)

* feat: make refresh update the signing key type of sessions

* chore: update changelog

* Merge 8.0 (#103)

* fix: remove db password from logs (#89)

* fix: remove db password from logs

* fix: mask db password

* fix: Add tests

* fix: Add more tests

* fix: PR changes

* fix: tests for connection pool (#90)

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: cicd tests (#92)

* fix: logging test (#93)

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: flaky test (#94)

* fix: make connection pool test less flaky

* fix: test

* fix: typo

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: adds idle timeout and minimum idle configs (#95)

* fix: idle connection configs

* test: protected configs

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: cicd (#96)

* fix: cicd

* fix: test

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: typo (#97)

* adding dev-v5.0.6 tag to this commit to ensure building

* fixes tests

* adding dev-v5.0.6 tag to this commit to ensure building

* fix: Vulnerability fix (#98)

* fix: updated dependencies

* chore: version and changelog

* fix: versions

* adding dev-v5.0.7 tag to this commit to ensure building

* fix: dependencies (#101)

* fix: dependency fix

* fix: dep fix

* adding dev-v5.0.7 tag to this commit to ensure building

* fix: fixes storage handling for non-auth recipes (#102)

* fix: non-auth fix

* fix: migration script and test fixes

* fix: plugin interface version

* fix: remove unnecessary func

* adding dev-v6.0.0 tag to this commit to ensure building

---------

Co-authored-by: Ankit Tiwari <ankucodes@gmail.com>
Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com>

* fix: mysql (#104)

---------

Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>
Co-authored-by: Ankit Tiwari <ankucodes@gmail.com>
Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants