feat: detect email_change_not_allowed earlier to fix tests

supertokens · Sep 30, 2024 · 47df0a2 · 47df0a2
1 parent bc7403d
commit 47df0a2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/build/recipe/thirdparty/api/implementation.js b/lib/build/recipe/thirdparty/api/implementation.js
@@ -132,6 +132,17 @@ function getAPIInterface() {
                 shouldTryLinkingWithSessionUser: input.shouldTryLinkingWithSessionUser,
             });
             if (preAuthChecks.status !== "OK") {
+                if (
+                    preAuthChecks.status === "SIGN_IN_NOT_ALLOWED" &&
+                    authenticatingUser !== undefined &&
+                    !authenticatingUser.loginMethod.hasSameEmailAs(emailInfo.id)
+                ) {
+                    return {
+                        status: "SIGN_IN_UP_NOT_ALLOWED",
+                        reason:
+                            "Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ERR_CODE_005)",
+                    };
+                }
                 logger_1.logDebugMessage(
                     "signInUpPOST: erroring out because preAuthChecks returned " + preAuthChecks.status
                 );

diff --git a/lib/ts/recipe/thirdparty/api/implementation.ts b/lib/ts/recipe/thirdparty/api/implementation.ts
@@ -142,6 +142,17 @@ export default function getAPIInterface(): APIInterface {
             });
 
             if (preAuthChecks.status !== "OK") {
+                if (
+                    preAuthChecks.status === "SIGN_IN_NOT_ALLOWED" &&
+                    authenticatingUser !== undefined &&
+                    !authenticatingUser.loginMethod.hasSameEmailAs(emailInfo.id)
+                ) {
+                    return {
+                        status: "SIGN_IN_UP_NOT_ALLOWED",
+                        reason:
+                            "Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ERR_CODE_005)",
+                    };
+                }
                 logDebugMessage("signInUpPOST: erroring out because preAuthChecks returned " + preAuthChecks.status);
                 // On the frontend, this should show a UI of asking the user
                 // to login using a different method.