fix: failing tests for domain parse util function

This commit fixes the updated domain parse util function (that uses
tldts) to make sure all tests pass.

lib/ts/utils.ts

@@ -345,11 +345,19 @@ export function getTopLevelDomainForSameSiteResolution(url: string): string {
         return "localhost";
     }
 
+    // According to tests, if it is an ec2 subdomain, we want to return the subdomain
+    // as well. With `psl` library, this was not an issue because the library
+    // would return a `null` value for `domain` for ec2 urls.
+    //
+    // With tldts library, it parses the ec2 urls and returns the .amazonaws.com
+    // as the domain (instead of `null`) so we need to do the amazonaws check
+    // regardless of the domain being null.
+    if (hostname.endsWith(".amazonaws.com")) {
+        return hostname;
+    }
+
     let parsedURL = parse(hostname);
     if (!parsedURL.domain) {
-        if (hostname.endsWith(".amazonaws.com") && parsedURL.publicSuffix === hostname) {
-            return hostname;
-        }
         // support for .local domain
         if (hostname.endsWith(".local") && !parsedURL.publicSuffix) {
             return hostname;

test/utils.test.js

@@ -40,9 +40,10 @@ describe("getTopLevelDomainForSameSiteResolution test", () => {
         assert.equal(getTopLevelDomainForSameSiteResolution("http://sub.domain.co.uk"), "domain.co.uk");
     });
 
-    it("should handle .amazonaws.com domains correctly", () => {
-        assert.equal(getTopLevelDomainForSameSiteResolution("https://my-instance.amazonaws.com"), "amazonaws.com");
-    });
+    assert.strictEqual(
+        getTopLevelDomainForSameSiteResolution("https://ec2-xx-yyy-zzz-0.compute-1.amazonaws.com"),
+        "ec2-xx-yyy-zzz-0.compute-1.amazonaws.com"
+    );
 
     it("should handle .local domains correctly", () => {
         assert.equal(getTopLevelDomainForSameSiteResolution("http://myserver.local"), "myserver.local");