Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multitenancy passwordless implementation #606

Merged
merged 13 commits into from
Jun 28, 2023
Merged

fix: multitenancy passwordless implementation #606

merged 13 commits into from
Jun 28, 2023

Conversation

sattvikc
Copy link
Collaborator

@sattvikc sattvikc commented Jun 23, 2023 •
edited by rishabhpoddar
Loading

Summary of change

  • tenantId in email and sms delivery
  • emailverification implementation
  • passwordless implementation
  • thirdparty implementation

Related issues

#471

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Item1
  • Item2

@sattvikc sattvikc self-assigned this Jun 23, 2023
rishabhpoddar
rishabhpoddar requested changes Jun 27, 2023
View reviewed changes
lib/ts/recipe/emailpassword/index.ts Outdated Show resolved Hide resolved
lib/build/recipe/emailverification/api/implementation.js Outdated Show resolved Hide resolved
lib/ts/recipe/emailverification/api/implementation.ts Show resolved Hide resolved
lib/ts/recipe/emailverification/index.ts Outdated Show resolved Hide resolved
lib/ts/recipe/emailverification/utils.ts Outdated Show resolved Hide resolved
lib/ts/recipe/thirdpartyemailpassword/index.ts Outdated Show resolved Hide resolved
lib/ts/recipe/thirdpartyemailpassword/index.ts Outdated Show resolved Hide resolved
lib/ts/recipe/thirdpartypasswordless/index.ts Outdated Show resolved Hide resolved
lib/ts/recipe/thirdpartypasswordless/index.ts Outdated Show resolved Hide resolved
lib/ts/recipe/thirdpartypasswordless/index.ts Show resolved Hide resolved
rishabhpoddar
rishabhpoddar requested changes Jun 28, 2023
View reviewed changes
lib/ts/recipe/thirdparty/api/implementation.ts Outdated Show resolved Hide resolved
lib/ts/recipe/thirdparty/api/implementation.ts Outdated Show resolved Hide resolved
lib/ts/recipe/thirdparty/api/implementation.ts Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar merged commit bd0fc62 into feat/tp-rework Jun 28, 2023
@rishabhpoddar rishabhpoddar deleted the mt-passwordless branch June 28, 2023 06:26
@sattvikc sattvikc mentioned this pull request Jul 11, 2023
Merged
rishabhpoddar added a commit that referenced this pull request Jul 19, 2023
@sattvikc @rishabhpoddar
@porcellus @nkshah2
feat: thirdparty re-work (#471)
183c673 
* fix: tp-rework interfaces, api impl

* fix: todos

* fix: iface change

* fix: further changes in thirdparty recipe

* fix: unused import

* fix: added requireEmail

* fix: minor fixes

* fix: interfaces fixes + ad apple impl

* fix: boxy, discord impl

* fix: fb impl

* fix: github impl

* fix: github impl

* fix: google and gw impl

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: updated provider impls

* fix: multitenancy recipe

* fix: recipe fixes

* fix: api impl fixes

* fix: impl fixes

* fix: tp-rework fixes

* fix: tp-rework fixes

* fix: tp-rework fixes

* fix: linkedin and okta impl

* fix: tp-rework fixes

* fix: fixed tests

* fix: fixed tests

* fix: updated for tenantId in core

* fix: rebuild

* fix: router to handle tenantid (#592)

* fix: router to handle tenantid

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: multitenancy recipe (#594)

* fix: impl and test

* fix: version

* fix: impl

* fix: pr comments

* fix: version update

* fix: pr comments

* fix: user context refactor (#595)

* fix: first layer impl

* fix: impl

* fix: pr comment

* fix: pr comments

* fix: test for counting makeDefaultUserContext

* fix: impl (#596)

* fix: pr comment (#597)

* fix: userroles mt impl (#600)

* fix: multitenancy emailpassword impl (#602)

* fix: recipe impl

* fix: impl

* fix: password reset link

* fix: mt revert

* fix: test

* fix: pr comment

* fix: tenantId compulsory in user roles recipe interface (#605)

* fix: multitenancy passwordless implementation (#606)

* fix: impl

* fix: test

* fix: cleanup

* fix: tenantId in link

* fix: tp and ev impl

* fix: ev impl

* fix: tp test

* fix: test cross tenant resend code

* fix: tenantId in link

* fix: pr comments

* fix: optional members in UserInfo

* fix: type exports

* fix: pr comments

* fix: session recipe impl for multitenancy (#607)

* fix: impl

* fix: test

* fix: cleanup

* fix: tenantId in link

* fix: tp and ev impl

* fix: ev impl

* fix: tp test

* fix: test cross tenant resend code

* fix: tenantId in link

* fix: pr comments

* fix: recipe impl

* fix: test

* fix: create new session

* fix: test

* fix: getTenantId

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: dashboard multitenancy updates (#623)

* fix: dashboard updates

* fix: pr comments

* fix: updating send email verification interface (#625)

* fix: updating send email verification interface

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: password reset email (#626)

* fix: passwordless

* fix: password reset in tpep

* fix: rename functions

* fix: tenantid in config functions (#627)

* fix: passwordless

* fix: password reset in tpep

* fix: rename functions

* fix: tenantId in types

* fix: tenantId in types

* fix: impl

* fix: impl

* fix: pr comments

* fix: minor

* Update lib/ts/recipe/emailpassword/utils.ts

* Update lib/ts/recipe/emailverification/utils.ts

* Update lib/ts/recipe/passwordless/utils.ts

* Update lib/ts/recipe/thirdpartyemailpassword/utils.ts

* Update lib/ts/recipe/thirdpartypasswordless/utils.ts

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>

* fix: missed param (#629)

* fix: return updated access token after verification

* test: fix clientId casing in tests

* Update routing logic for Hapi and dashboard recipe to account for multitenancy (#631)

* fix: test fixes (#630)

* fix: test fixes

* fix: claims build

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: cleanup

* fix: tests

* fix: tests

* fix: pr comments

* fix: remove error handlers in multitenancy recipe (#632)

* fix: test fixes

* fix: claims build

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: cleanup

* fix: tests

* fix: tests

* fix: pr comments

* fix: remove error handlers in multitenancy

* fix: pr comments

* fix: pr comments

* fix: tenantid compulsory (#633)

* fix: tenantid compulsory

* fix: type fix

* fix: type fix

* fix: tenant id in get global claim validators (#634)

* fix: tenant id in global claim validators

* fix: pr comments

* refactor: Remove core config from dashboard tenants list response (#635)

* Remove core config from dashboard tenants list response

* Update tenant list API logic

* fix: Fix tenant id being passed in the wrong order for password update functions (#636)

* Remove core config from dashboard tenants list response

* Fix tenant id being passed in the wrong order for password update functions

* Add user PUT api to list

* Update tenant list API logic

* Update CHANGELOG

* fix: all tests fixes (#637)

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: test

* fix: tests

* fix: tests

* fix: test (#638)

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: test

* fix: tests

* fix: tests

* fix: tests

* fix: handle tenant not found error (#639)

* fix: handle tenant not found error

* fix: pr comments

* fix: pr comments

* docs: convert next example to use app dir (#641)

* fix: bitbucket gitlab impl and other fixes (#642)

* fix: github

* fix: user info

* fix: discord and linkedin

* fix: gitlab impl

* fix: bitbucket impl

* fix: tests fixes (#643)

* fix: tests

* fix: tests

* fix: framework tests with tenantid in path

* fix: tests

* fix: google workspaces

* fix: version updates and changelog (#645)

* fix: tests

* fix: tests

* fix: framework tests with tenantid in path

* fix: tests

* fix: google workspaces

* fix: version updates

* chore: changelog

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: auth react server (#647)

* fix: auth-react-server

* fix: auth-react-server

* fix: example test (#648)

* removes unnecessary import

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>
Co-authored-by: Mihaly Lengyel <mihaly@lengyel.tech>
Co-authored-by: Nemi Shah <nemishah1212@gmail.com>
@KShivendu KShivendu mentioned this pull request Jul 26, 2023
Merged
9 tasks
This was referenced Jul 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhpoddar rishabhpoddar rishabhpoddar approved these changes

Assignees

@sattvikc sattvikc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sattvikc @rishabhpoddar