Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: aws test now creates one layer for one PR #649

Merged
merged 33 commits into from
Jul 20, 2023
Merged

Conversation

iresharma
Copy link
Contributor

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Item1
  • Item2

@rishabhpoddar rishabhpoddar merged commit 15aa5a0 into 15.0 Jul 20, 2023
11 of 13 checks passed
@rishabhpoddar rishabhpoddar deleted the test/aws branch July 20, 2023 12:08
sattvikc pushed a commit that referenced this pull request Jul 21, 2023
* aws lambda test

* function name moved to env

* express revert

* workflow minor fix

* testing

* npm runner fix

* npm runner fix

* fix test

* install for layer moved to path

* install from git

* action variable change

* action variable change

* action variable change

* action variable change

* fix express change

* readme added

* changed api domain

* lambda function name

* function name fix

* wait for navigation added

* avoid creating multiple layers

* Update basic.test.js

* Update aws-lambda.js

* avoid creating multiple layers

* avoid creating multiple layers

* updated helper to delete older layers

* debug

* debug to see which layer is being deleted

* debug to see which layer is being deleted

* debug to see which layer is being deleted

* debug to see which layer is being deleted

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>
rishabhpoddar added a commit that referenced this pull request Jul 21, 2023
* fix: user info

* fix: google user info map

* fix: google user info map

* fix: thirdparty in combination recipe

* test: aws test now creates one layer for one PR (#649)

* aws lambda test

* function name moved to env

* express revert

* workflow minor fix

* testing

* npm runner fix

* npm runner fix

* fix test

* install for layer moved to path

* install from git

* action variable change

* action variable change

* action variable change

* action variable change

* fix express change

* readme added

* changed api domain

* lambda function name

* function name fix

* wait for navigation added

* avoid creating multiple layers

* Update basic.test.js

* Update aws-lambda.js

* avoid creating multiple layers

* avoid creating multiple layers

* updated helper to delete older layers

* debug

* debug to see which layer is being deleted

* debug to see which layer is being deleted

* debug to see which layer is being deleted

* debug to see which layer is being deleted

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>

* fixes parsing issue in api for emailpassword

* fix: user info map config

* fix: providers

* fix: tests

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>
Co-authored-by: Iresh Sharma <32684272+iresharma@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants