feat: Add validateAccessToken function to providers #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…access token received from the providers
rishabhpoddar
requested changes
Sep 29, 2023
Comment on lines
343
to
349
| if (impl.config.validateAccessToken !== undefined) { | ||
| await impl.config.validateAccessToken({ | ||
| accessToken: accessToken, | ||
| clientConfig: impl.config, | ||
| userContext, | ||
| }); | ||
| } |
There was a problem hiding this comment.
this should happen before the above if and we need to check if the access token is undefined or not
Comment on lines
33
to
39
| // if (input.config.validateAccessToken === undefined) { | ||
| // input.config.validateAccessToken = async ({ accessTokenPayload, clientConfig }) => { | ||
| // if (accessTokenPayload.aud !== clientConfig.clientId) { | ||
| // throw Error("accessTokenPayload.aud does not match clientId"); | ||
| // } | ||
| // }; | ||
| // } |
lib/ts/version.ts
Outdated
| @@ -12,7 +12,7 @@ | |||
| * License for the specific language governing permissions and limitations | |||
| * under the License. | |||
| */ | |||
| export const version = "16.0.0"; | |||
| export const version = "16.0.1"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).Remaining TODOs for this PR