-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add edge function testing #704
Merged
porcellus
merged 11 commits into
supertokens:feat/edge_function_compatibility
from
porcellus:feat/add-netlify-deploy-to-example
Sep 29, 2023
Merged
feat: add edge function testing #704
porcellus
merged 11 commits into
supertokens:feat/edge_function_compatibility
from
porcellus:feat/add-netlify-deploy-to-example
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for precious-marshmallow-968a81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
porcellus
changed the base branch from
master
to
feat/edge_function_compatibility
September 29, 2023 15:24
…ty' into feat/add-netlify-deploy-to-example
…-deploy-to-example
porcellus
merged commit Sep 29, 2023
64111cc
into
supertokens:feat/edge_function_compatibility
3 of 4 checks passed
rishabhpoddar
added a commit
that referenced
this pull request
Oct 10, 2023
* feat: use built-in fetch when available * chore: bump version * feat: make it possible to use our middleware in some unsupported frameworks * feat: add edge function testing (#704) * feat: add netlify.toml to next example * docs(examples): add postinstall script to install root deps in CI deploys * docs(examples): update appinfo to point to the netlify deployment if defined * docs(examples): update appinfo to point to the netlify deployment * docs(examples): update appinfo to point to the netlify deployment * test: update example tests * chore: prettier * test: add edge function test * test: make sure the nextjs test call refresh to check edge compatibility * test: add shebang to utils script * test: save the output of the deployment in case of a failure * test: save the output of the deployment in case of a failure * test: use netlify_site_id secret * test: build before deploying to netlify * test: add TEST_DEPLOYED_VERSION flag to the edge function test gh action * test: check if prod deploy in netlify works * ci: debug netlify deployment * ci: fixing netlify test deployment * ci: fixing netlify test deployment * ci: remove earlier fix to check if test fails in CI * Revert "ci: remove earlier fix to check if test fails in CI" This reverts commit f4aeedd. * feat: move handleCall from nextjs appdir example * fix: getAppDirRequestHandler export * feat: PartialNextRequest should accept string as method * build: ignore new util script when publishing * feat: add verifySession for custom frameworks with a new callback to save the session obj * feat: add export for custom framework verifySession * test: add type checking test for getAppDirRequestHandler and custom framework verifySession * feat: add custom as an option to the framework config * test: add tests for custom framework --------- Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
recipe/thirdparty/providers/configUtils.ts
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.add-ts-no-check.js
file to include thatsomeFunc: function () {..}
).Remaining TODOs for this PR