Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add edge function testing #704

Conversation

porcellus
Copy link
Collaborator

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Item1
  • Item2

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for precious-marshmallow-968a81 ready!

Name Link
🔨 Latest commit bd99b56
🔍 Latest deploy log https://app.netlify.com/sites/precious-marshmallow-968a81/deploys/6516eb6aae3ea200082da069
😎 Deploy Preview https://deploy-preview-704--precious-marshmallow-968a81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@porcellus porcellus changed the base branch from master to feat/edge_function_compatibility September 29, 2023 15:24
@porcellus porcellus merged commit 64111cc into supertokens:feat/edge_function_compatibility Sep 29, 2023
3 of 4 checks passed
@porcellus porcellus deleted the feat/add-netlify-deploy-to-example branch September 29, 2023 15:45
rishabhpoddar added a commit that referenced this pull request Oct 10, 2023
* feat: use built-in fetch when available

* chore: bump version

* feat: make it possible to use our middleware in some unsupported frameworks

* feat: add edge function testing (#704)

* feat: add netlify.toml to next example

* docs(examples): add postinstall script to install root deps in CI deploys

* docs(examples): update appinfo to point to the netlify deployment if defined

* docs(examples): update appinfo to point to the netlify deployment

* docs(examples): update appinfo to point to the netlify deployment

* test: update example tests

* chore: prettier

* test: add edge function test

* test: make sure the nextjs test call refresh to check edge compatibility

* test: add shebang to utils script

* test: save the output of the deployment in case of a failure

* test: save the output of the deployment in case of a failure

* test: use netlify_site_id secret

* test: build before deploying to netlify

* test: add TEST_DEPLOYED_VERSION flag to the edge function test gh action

* test: check if prod deploy in netlify works

* ci: debug netlify deployment

* ci: fixing netlify test deployment

* ci: fixing netlify test deployment

* ci: remove earlier fix to check if test fails in CI

* Revert "ci: remove earlier fix to check if test fails in CI"

This reverts commit f4aeedd.

* feat: move handleCall from nextjs appdir example

* fix: getAppDirRequestHandler export

* feat: PartialNextRequest should accept string as method

* build: ignore new util script when publishing

* feat: add verifySession for custom frameworks with a new callback to save the session obj

* feat: add export for custom framework verifySession

* test: add type checking test for getAppDirRequestHandler and custom framework verifySession

* feat: add custom as an option to the framework config

* test: add tests for custom framework

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant