Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor app info type to allow adding multiple website domains #706

Merged
merged 35 commits into from
Oct 10, 2023

Conversation

nkshah2
Copy link
Contributor

@nkshah2 nkshah2 commented Oct 4, 2023

Summary of change

  • Allows for multiple frontend domains to be configured
  • Adds origin to app info which can be used to provide a function as the frontend domain instead of websiteDomain which only accepts a string

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Unit tests
  • Update CHANGELOG

lib/ts/utils.ts Show resolved Hide resolved
lib/ts/recipe/session/utils.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/utils.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/cookieAndHeaders.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/recipe.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/sessionClass.ts Outdated Show resolved Hide resolved
lib/ts/recipe/dashboard/api/analytics.ts Show resolved Hide resolved
lib/ts/recipe/emailverification/utils.ts Outdated Show resolved Hide resolved
lib/ts/recipe/passwordless/recipe.ts Outdated Show resolved Hide resolved
lib/ts/recipe/emailpassword/utils.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/utils.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/utils.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/recipe.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/sessionClass.ts Outdated Show resolved Hide resolved
lib/ts/recipe/session/sessionClass.ts Outdated Show resolved Hide resolved
lib/ts/recipe/dashboard/api/analytics.ts Outdated Show resolved Hide resolved
lib/ts/recipe/passwordless/recipe.ts Show resolved Hide resolved
@rishabhpoddar rishabhpoddar changed the base branch from 16.2 to 16.3 October 10, 2023 06:40
@rishabhpoddar rishabhpoddar marked this pull request as ready for review October 10, 2023 11:46
@rishabhpoddar rishabhpoddar merged commit fa8301f into 16.3 Oct 10, 2023
4 of 13 checks passed
@rishabhpoddar rishabhpoddar deleted the appinfo-refactor branch October 10, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants