Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: userroles and permission on dashboard recipe #718

Merged
merged 27 commits into from
Nov 23, 2023

Conversation

Chakravarthy7102
Copy link
Contributor

@Chakravarthy7102 Chakravarthy7102 commented Oct 16, 2023

Summary of change

adds userroles and permissions to dashboard recipe.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Item1
  • Item2

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for precious-marshmallow-968a81 canceled.

Name Link
🔨 Latest commit cc81759
🔍 Latest deploy log https://app.netlify.com/sites/precious-marshmallow-968a81/deploys/652cd1f03f8b3e000840dc0d

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for astounding-pegasus-21c111 canceled.

Name Link
🔨 Latest commit cc81759
🔍 Latest deploy log https://app.netlify.com/sites/astounding-pegasus-21c111/deploys/652cd1f0f7f53d0008cf9233

@Chakravarthy7102 Chakravarthy7102 changed the title init userroles and permission on dashboard feat: userroles and permission on dashboard recipe Oct 16, 2023
@Chakravarthy7102 Chakravarthy7102 marked this pull request as draft October 16, 2023 06:02
@Chakravarthy7102 Chakravarthy7102 changed the base branch from master to 16.3 October 16, 2023 06:03
@Chakravarthy7102 Chakravarthy7102 marked this pull request as ready for review November 2, 2023 05:33
lib/ts/recipe/dashboard/api/userroles/addRoleToUser.ts Outdated Show resolved Hide resolved
lib/ts/recipe/dashboard/api/userroles/roles/getAllRoles.ts Outdated Show resolved Hide resolved
lib/ts/recipe/dashboard/api/userroles/roles/getAllRoles.ts Outdated Show resolved Hide resolved
lib/ts/recipe/dashboard/api/userroles/roles/getAllRoles.ts Outdated Show resolved Hide resolved
lib/ts/recipe/dashboard/recipe.ts Show resolved Hide resolved
lib/ts/recipe/dashboard/recipe.ts Outdated Show resolved Hide resolved
@Chakravarthy7102 Chakravarthy7102 changed the base branch from 16.3 to 16.5 November 10, 2023 05:33
@rishabhpoddar rishabhpoddar changed the base branch from 16.5 to 16.6 November 23, 2023 06:26
@rishabhpoddar rishabhpoddar merged commit 76156be into 16.6 Nov 23, 2023
12 of 14 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/dashboard-userroles branch November 23, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants