Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make edge workflows work properly #925

Merged
merged 8 commits into from
Sep 23, 2024
Merged

fix: Make edge workflows work properly #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3a2658d
Update workflows to hardcode some variables
deepjyoti30-st Sep 23, 2024
07fd969
Fix hono deployed app URL for tests to pass
deepjyoti30-st Sep 23, 2024
24ccc68
Add protocol in the hono URL to make tests pass
deepjyoti30-st Sep 23, 2024
8a857ae
Add possible fix for hono workflow test
deepjyoti30-st Sep 23, 2024
9f26e61
Remove obsolte edge function test in workflow
deepjyoti30-st Sep 23, 2024
bb7e1fc
Make hono start command use run-all
deepjyoti30-st Sep 23, 2024
e97dbc1
Fix hono example test to run with all tests
deepjyoti30-st Sep 23, 2024
0c10c0e
Make hono example return 200 OK on root route
deepjyoti30-st Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-cf-worker-hono.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ jobs:
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
APP_URL: ${{ secrets.CLOUDFLARE_HONO_APP_URL }}
CLOUDFLARE_PROJECT_NAME: ${{ secrets.CLOUDFLARE_HONO_PROJECT_NAME }}
APP_URL: "https://hono.rishabh-77b.workers.dev"
CLOUDFLARE_PROJECT_NAME: "hono"
TEST_DEPLOYED_VERSION: true
defaults:
run:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-cf-worker-next.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ jobs:
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
APP_URL: ${{ secrets.CLOUDFLARE_APP_URL }}
CLOUDFLARE_PROJECT_NAME: ${{ secrets.CLOUDFLARE_PROJECT_NAME }}
APP_URL: "supertokens-node-b95.pages.dev"
CLOUDFLARE_PROJECT_NAME: "supertokens-node-pr-check-for-edge-function-compat"
TEST_DEPLOYED_VERSION: true
defaults:
run:
Expand Down
34 changes: 0 additions & 34 deletions .github/workflows/test-edge-function.yml
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions examples/cloudflare-workers/with-email-password-hono-be-only/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,10 @@ app.get("/sessioninfo", (c) => {
});
});

app.get("/", (c) => {
return c.json({
"message": "Hello from Supertokens"
})
})

export default app;
2 changes: 1 addition & 1 deletion examples/cloudflare-workers/with-email-password-hono-be-only/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "",
"main": "index.js",
"scripts": {
"start": "wrangler dev index.ts --port 3001"
"start": "wrangler dev index.ts --port 3000"
},
"dependencies": {
"hono": "^4.3.9",
Expand Down
2 changes: 1 addition & 1 deletion examples/cloudflare-workers/with-email-password-hono-be-only/test/basic.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const assert = require("assert");
// Run the tests in a DOM environment.
require("jsdom-global")();

const APP_URL = process.env.APP_URL || "http://localhost:8787";
const APP_URL = process.env.APP_URL || "http://localhost:3000";

describe("Auth API Tests", () => {
const signupBody = {
Expand Down
Loading