feat: Add passkeys support #942
Conversation
| // todo update this ??? | ||
| export type TypeEmailPasswordPasswordResetEmailDeliveryInput = { | ||
| type: "PASSWORD_RESET"; | ||
| user: { | ||
| id: string; | ||
| recipeUserId: RecipeUserId | undefined; | ||
| email: string; | ||
| }; | ||
| passwordResetLink: string; | ||
| tenantId: string; | ||
| }; | ||
|
|
||
| export type TypeEmailPasswordEmailDeliveryInput = TypeEmailPasswordPasswordResetEmailDeliveryInput; |
| // default implementation for the TypeInput | ||
| // todo update this ??? |
There was a problem hiding this comment.
| // default implementation for the TypeInput | |
| // todo update this ??? |
| export type RecipeInterface = { | ||
| registerPasskeyOptions(input: { | ||
| email: string; | ||
| password: string; |
There was a problem hiding this comment.
| password: string; |
| registerPasskeyOptions(input: { | ||
| email: string; | ||
| password: string; | ||
| session: SessionContainerInterface | undefined; |
There was a problem hiding this comment.
| session: SessionContainerInterface | undefined; |
| tenantId: string; | ||
| userContext: UserContext; | ||
| }): Promise<{ | ||
| status: "OK"; |
There was a problem hiding this comment.
Are there any failure cases in this API?
| status: "OK"; | ||
| passkeyGeneratedOptionsId: string; | ||
| rp: { | ||
| id: string; |
There was a problem hiding this comment.
where are we getting the id from?
| name: string; | ||
| displayName: string; |
There was a problem hiding this comment.
where are these two coming from?
| user: User; | ||
| recipeUserId: RecipeUserId; | ||
| } | ||
| | { status: "EMAIL_ALREADY_EXISTS_ERROR" } |
There was a problem hiding this comment.
not sure if this is the best way, cause if this error comes, but the user has already added a passkey in their browser, so it would get confusing
There was a problem hiding this comment.
So instead, we should have this type of error in the part where we are generating a passkeyoption for the purpose of sign up?
| userContext: UserContext; | ||
| }): Promise< | ||
| | { status: "OK"; user: User; recipeUserId: RecipeUserId } | ||
| | { status: "WRONG_CREDENTIALS_ERROR" } |
There was a problem hiding this comment.
Should we call this WRONG_CREDENTIALS_ERROR or something else?
| userContext: UserContext; | ||
| }): Promise<{ status: "OK"; token: string } | { status: "UNKNOWN_USER_ID_ERROR" }>; | ||
|
|
||
| consumeRecoverAccountToken(input: { |
There was a problem hiding this comment.
how will this work? LIke the user has to first generate a passkey options right and then call this function after?
Summary of change
Add passkeys support
Related issues
Test Plan
More details here: https://docs.google.com/document/d/1G7tO9_dSNi8wur3ajGg4pq-wiHatKDbHv2sBt-uSbQg/edit