Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds caching for querier #508

Merged
merged 4 commits into from
Jun 6, 2024
Merged

adds caching for querier #508

merged 4 commits into from
Jun 6, 2024

Conversation

rishabhpoddar
Copy link
Member

@rishabhpoddar rishabhpoddar commented Jun 4, 2024

Summary of change

Adds caching to querier so that core calls are reduced. The cache is invalidated anytime a non GET API call is made.

Test Plan

Lots of tests

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Any race condition issues?

@rishabhpoddar rishabhpoddar marked this pull request as ready for review June 5, 2024 08:12
@rishabhpoddar rishabhpoddar changed the base branch from 0.21 to 0.22 June 6, 2024 06:16
@rishabhpoddar rishabhpoddar merged commit f817c5e into 0.22 Jun 6, 2024
15 of 41 checks passed
@rishabhpoddar rishabhpoddar deleted the adds-caching-to-querier branch June 6, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants