Merge pull request #201 from superwall/develop

1.4.0-beta.3
superwall · Nov 7, 2024 · b63bc36 · b63bc36
2 parents 4216e0c + 5c1b48c
commit b63bc36
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 The changelog for `Superwall`. Also see the [releases](https://github.com/superwall/Superwall-Android/releases) on GitHub.
 
+## 1.4.0-beta.3
+
+- Fixes issue where paywalls without fallback would fail to load and missing resource would cause a failure event
+
 ## 1.4.0-beta.2
 
 ## Enhancements

diff --git a/superwall/build.gradle.kts b/superwall/build.gradle.kts
@@ -23,7 +23,7 @@ plugins {
     id("signing")
 }
 
-version = "1.4.0-beta.2"
+version = "1.4.0-beta.3"
 
 android {
     compileSdk = 34

diff --git a/superwall/src/main/java/com/superwall/sdk/paywall/vc/PaywallView.kt b/superwall/src/main/java/com/superwall/sdk/paywall/vc/PaywallView.kt
@@ -701,7 +701,7 @@ class PaywallView(
                 if (useMultipleUrls) {
                     webView.loadPaywallWithFallbackUrl(paywall)
                 } else {
-                    webView.loadUrl(url.toString())
+                    webView.loadUrl(url.value)
                 }
             }
 

diff --git a/superwall/src/main/java/com/superwall/sdk/paywall/vc/web_view/DefaultWebviewClient.kt b/superwall/src/main/java/com/superwall/sdk/paywall/vc/web_view/DefaultWebviewClient.kt
@@ -44,6 +44,10 @@ internal open class DefaultWebviewClient(
         request: WebResourceRequest?,
         errorResponse: WebResourceResponse?,
     ) {
+        val requestUrl = request?.url.toString()
+        if (requestUrl.contains("favicon.ico")) {
+            return
+        }
         ioScope.launch {
             webviewClientEvents.emit(
                 WebviewClientEvent.OnError(