-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.10.0 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/purchasing-api
- Makes loading state a @published public property. - Updates objc delegate method from `didChangeWithLoadingState` to `loadingStateDidChange`. - Removes `loadingStatePublisher` in favour of published property. - Removes `PaywallLoadingStateObjc` because PaywallLoadingState is objc friendly already. - Updates the change log. - Updates documentation. - Swiftlint fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Enhancements
purchase(_:)
to initiate a purchase of anSKProduct
via Superwall regardless of whether you are using paywalls or not.restorePurchases()
to restore purchases via Superwall.paywall(_:loadingStateDidChange)
function to thePaywallViewControllerDelegate
. This is called when the loading state of the presentedPaywallViewController
did change.loadingState
on thePaywallViewController
a public published property.Fixes
Notes
The objective-c versions of the UI tests don't seem to work as expected, there's something wrong with the asserts in the tests not getting hit rather than SuperwallKit.
Checklist
CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.swiftlint
in the main directory and fixed any issues.