-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce complexity when parsing content #14
Labels
good first issue
Good for newcomers
refactoring
Issues or PRs to improving code structure, without changing its external behavior
Comments
@supitsdu hello there, working on my first issue. I've forked the repo and will give this a try. |
karimalzalek
added a commit
to karimalzalek/clipper
that referenced
this issue
Jun 24, 2024
I have forked the code, made the changes and create a PR, let me know what you think of the changes. Thanks. |
I would like you to reopen the issue, because my code reviews was missed (by my fault) Please have a look here |
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
refactoring
Issues or PRs to improving code structure, without changing its external behavior
The complexity of the code was increased with #13 by the multiple branching if
The parsing of the content could be moved out the main with something like this
Originally posted by @ccoVeille in #13 (comment)
The text was updated successfully, but these errors were encountered: