Add ff/mont32_t.cuh, a generalized template for <=32-bit moduli. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandsentinel
approved these changes
Jun 17, 2024
dot-asm
force-pushed
the
mont32_t
branch
2 times, most recently
from
f2f7343
to
a030ac3
Compare
ff/baby_bear.hpp
Outdated
| # if defined(_GLIBCXX_IOSTREAM) || defined(_IOSTREAM_) // non-standard | ||
| friend std::ostream& operator<<(std::ostream& os, const bb31_4_t& a) | ||
| { | ||
| os << "[" << a.c[0] << ", " a.c[1] << ", " a.c[2] << ", " << a.c[3] << "]"; |
There was a problem hiding this comment.
There's a missing << here.
Users are more likely than not have to pass -DBABY_BEAR_CANONICAL to the compiler, because not doing so aligns this implementation with a noncanonical implementation in RISC Zero.
LDE_spread_distribute_powers was producing incorrect results in lg_blowup > lg_domain_size cases, which can occur in tests.
Customarily one uses primitive root as generator, but RISC Zero used an alternative generator, which remains the default choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[and some other adjustments.]